SRL Archive - RS3 Outdated / Broken Scripts

fishy for srl4


munk

2007-09-08 00:58:23

                                                                                {
____|_) | [SRL4][#14]
| | __| __ \ | |
__| |\__ \ | | | | |
_| _|____/_| |_|\__, |
by munk ____/

}

Fishes and cooks all types of f2p fish.

Instructions
Locations
For Net fishing, and sea baiting, setup player in the Al Kahrid Bank. THERE IS NO DRAYNOR NETTING, no stoves are close enough. For flyrod fishing, and river baiting, place the player in Edgeville Bank. For caging and harpooning place player in Draynor Bank. You do not need to setup the players inventory in any way, the script will handle it:)
Cooking
Each player is given the option to cook the fish it catches. Players[#].booleans[0] can be set to true(cook) or false(don't cook). Locations were all chosen because a stove is near or on the way to the bank. I wrote cooking to not affect the script if it fails in any way, it will just bank the raw fish and go back to fishing.

//><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><>
// Setup
//
// PLAYERS[#].STRINGS[0] START
// 'net' or 'bait1' - Al kahrid Bank
// 'bait2' or 'flyrod' - Edgeville Bank
// 'harpoon' or 'cage' - Draynor Bank
//
// PLAYERS[#].BOOLEANS[0]
// true/false - Cook the fish?
//
//><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><> ><>

Features
- 99.999% tested whirlpool finding
- Custom Equipment Finding
- Walkin backups on top of more backups
- Detects if Pirates Treasure quest has been done for using Pay Fare option for karamja sailing
- much more!

Tips
- Keep extra equipment in back
- Read the last few pages of this thread if you are having any problems, a suggestion/fix is probably already posted


><>

20 Hours, 6 Minutes and 37 Seconds
345 Shrimps
193 Anchovies
301 Tuna
177 Lobster
79 Swordfish
1090 Cooked Shrimps
565 Cooked Anchovies

burnt 128 fish

<>< munk


updates
v1.0.1 - 4/09/08 - new stuff, I forgot what. Dl it!
v1.0.0 - 03/28/08 - Been a long time. Old version was tossed and new one was written from scratch. Working really good for me!
v0.4.0 - 10/14/07 - edgeville now uses openBankFast. All better:)
v0.3.8 - 10/05/07 - Fixed the edgeville update problems. Added SRL-stats for fun.
v0.3.1 - 09/24/07 - updated to rev#4(h)
v0.2.8 - 09/21/07 - added net fishing/cooking in alkahrid, and Karamja fishing. alot of stuff. still needs testing. please post some feedback/proggies/criticism/all that jazz.
v0.1 - 09/08/07 - better cooking and whirpool finding.

deaduar3

2007-09-08 07:12:59

looks very nice, i am just running it now, i will post the results in 30 mins :)……

the scar noob

2007-09-08 09:23:51

you're a new one, it's great to see those abilities from a new member!!!!
didn't really watched the code for 100% searching the errors or so, not really a lot of time, but i can say that you have to change that wwhirlpool bitmap :p
Use STM or j ust use the one in SRL :)

dendis

2007-09-08 13:20:12

it looks nice il test it tonight

munk

2007-09-09 00:58:43

From: the scar noob
you're a new one, it's great to see those abilities from a new member!!!!
didn't really watched the code for 100% searching the errors or so, not really a lot of time, but i can say that you have to change that wwhirlpool bitmap :p
Use STM or j ust use the one in SRL :)


edit: i got it workin with the srl dtm. ill update soon.

deaduar3

2007-09-09 09:08:34

Okay, i tried the old one , and yes the cooknig was not really great, it got stuck clicking on a trout sometimes and then clicking the stove but not clicking the last sentence to actually cook it.

Well anyway ill give the new version a go. thanks for the script…

–edit
Just tried the new version and it seemed to run good!, ran it for aprox 15 mins with no problems.

Negaal

2007-09-13 07:02:02

i'll give it a try:) i'm hoping you upgrade it to some l33t script:D

edit : i got my fishers above 30 fishing, i will give you nice proggy in few days

________________________________________________________________________-
edit:

From: the scar noob

People, stop saying you're going to post proggy if you aren't to..



Scar noob, i havent forgot my promise, i will post proggy(after i finish with wizzup's script)

munk

2007-09-13 22:01:08

From: negaal
i'll give it a try:) i'm hoping you upgrade it to some l33t script:D


<3 negaal

im actually slowly but surely finishing it right now. Its gonna end up as a complete fishing script. Youll be able to lvl a characters fishing with ease.

There will be netting in either draynor or alkahrid(havent chosen which yet), fly fishing(of course) and then karamja fishing(harpoon and cage), All in the same script.

any spare minute i get ive been workin on it but itll probably still be a while cause i got a busy couple'a weeks ahead of me.



to everyone, just because I didnt write "Post Progress/Feedback" doesnt mean i wouldnt mind seeing a few. Savages! :p

Nebuli

2007-09-14 14:58:33

Here's the proggy you wanted :) it's small because I just tested it for 1 load but it worked very nicely. The only problem was, that bank finding was slow but it worked.

><>
11 Minutes and 36 Seconds
Caught 26 Trout
Caught 0 Salmon
Cooked 17 Trout
Cooked 0 Salmon
Burned 0 fish
<>< munk

krazyk56

2007-09-16 19:58:22

ok, i can fish fine, but once i get a full load, and it says cant carry any more fish i get the error "[Runtime Error] : Out Of Range in line 274 in script C:\Program Files\SCAR 3.11\Scripts\fishy0.1.scar", it stops there and goes no further, any suggestions?

munk

2007-09-21 23:56:28

0.2.8 is posted. It nets, flyfishes, cages, and harpoons, and can cook at all locations. Its great for starting chracters on fishing and getting them to lobs/swords quick. It runs really solid. give it a try:D

krazyk56

2007-09-22 20:34:33

very nice, will post proggy soon

the scar noob

2007-09-23 04:44:56

this script should get more rep++
It looks a very good script!!!
Congratz dude on making such a nice script!!!
rep++ is deserved!
People, stop saying you're going to post proggy if you aren't to..

krazyk56

2007-10-04 13:13:44

hey,

i just tried the 0.3.1 and whenever it goes to bank/cook the fish, it just follows the river upstream, untill almost going into the wildy, im fishing in edgeville btw, is there any reason why its doing this?

Thanks

King of Knives

2007-10-04 14:41:20

It probably doesn't find the Bank symbol. Try to avoid autoing in busy worlds.

-Knives

munk

2007-10-04 18:11:09

ahh crap, ill update it soon. The new Edgeville bank screwed up my bankers DTM so it wont ever find the bank. hopefully ill get 0.3.8 posted tonight.


EDIT: hey knives, your sig made me laugh. Who actually wrote that?

12345678

2007-10-04 18:49:37

wow good job on the script ima test it over night, and i love your chicken figther worked straight 10 hours XD

munk

2007-10-04 21:36:48

0.3.8 is out. I suggest an update.

krazyk56

2007-10-04 21:42:38

Hey,

Thanks man, I will test it out now and post a proggy!

krazyk56

2007-10-04 21:58:16

[Player Report]
0 —- = T / banked 1 / -1 Trout, 14 Salmon / bank
[End]

><> 0.3.8
8 Minutes and 49 Seconds
Fished 14 Trout
Fished 10 Salmon
Cooked 14 Trout
Cooked 10 Salmon
Burned -1 fish
<>< munk

Well, it seems to be working now. This is just a quick proggie, I will post a better one when I have more time. I was just letting you know that it is working now, there is one slight thing, it doesnt bother much, its just when it goes to the bank, it lags quite a bit and it takes a while before it actually opens the bank up. It still works nonetheless it just seems like it causes a slight delay.

Thanks for one awesome script!

12345678

2007-10-05 12:29:29

hmm… the script works well but it doesnt bank for me =/
wait nvm the banking does work but takes a while

justl00king

2007-10-05 12:42:19

nice script gonna try this soon :)

munk

2007-10-05 14:07:34

everyone complaining about slow edgeville banking, i think that should be fixed now with rev#5 of SRL. give it a try.

Negaal

2007-10-08 02:12:06

3. if player's.skill = 'net' then
// position player in al kharid bank.
// 4. if player's.skill = 'flyrod' then
// position player in edgeville bank.
// 5. if player's.skill = 'cage' or 'harpoon' then
// position player in draynor bank.
// 6. Press Play.



why you have to make it so hard, using netter near al kharid bank, you can do it near drayanor aswell…?

Negaal

2007-10-08 16:05:40

it does not work if i use it in edge, i set cooking false, it fishes inv full walks to bank and thinks hes near cooking stove and becoms to lagg….:( i'm kinda 99% sure i set up all right

munk

2007-10-08 19:12:13

From: negaal
it does not work if i use it in edge, i set cooking false, it fishes inv full walks to bank and thinks hes near cooking stove and becoms to lagg….:( i'm kinda 99% sure i set up all right


hmm. ill have to take a look at that. I never tested without cooking:redface:
and as for netting in draynor, theres no stove nearby. Al kahrid has a very close stove at the kebab shop, and its much less crowded at all times. and the Scorpion serves as a low-level character checker:D

NCDS

2007-10-09 19:57:09

hmm i like this script alot, but after it makes one trip (cage fishing, if that matters) it stops to go to next player…even tho there is only 1 player used. suggestions?

munk

2007-10-09 20:59:03

From: n c d s
hmm i like this script alot, but after it makes one trip (cage fishing, if that matters) it stops to go to next player…even tho there is only 1 player used. suggestions?



use more than one player:p



im gonna do a complete revamp of this script with better edgeville banking and better walking to karamja. might be a week or so.

12345678

2007-10-13 17:36:34

im just wondering when your gonna update this script for the banking, but i really like this script

munk

2007-10-14 00:12:47

From: 12345678
im just wondering when your gonna update this script for the banking, but i really like this script


oh god, i totally forgot hold on….

EDIT: There! v0.4.0 will find edgeville bank fast.

ceapy

2007-10-18 19:11:02

Looks like a cool script but i got a problem! When I start the script (with a net in inv) in al-kharid bank, it just banks the net then logs me out and just sits there, is there something wrong? (im using scar 3.12, am i suppose to use 3.11? or will it still work with 3.12) also i get this hint

Line 55: [Hint] (14891:1): Variable 'I' never used in script C:\Documents and Settings\******\Desktop\Scripts\fishy0.4.0.scar

And also when I use the CAGE option, it just makes the angle go to the highest and then just sits there -_- I also only have srl 4 cuz i cant pick that srl revision thing -_-

12345678

2007-10-19 16:45:47

thanks for the great update im try and test it out soon XD

kingarabian

2007-10-22 20:21:56

Does it work in the fishing guild?

edit:nope it doesnt.

beanman

2007-10-22 20:24:53

i though you couldn't have free scripts that banked? or is that just limited to mining?

Lee Lok Hin

2007-10-30 05:59:10

My scar doesnt seem to want to use the function OpenBankFast. It just looks aroudn for anything that is brown (even remotely!) any ideas?

i tried using version 3.8 Same problem, but when i turned the angle, it half-worked…

br34d

2007-11-02 21:25:07

works great up untill bank. it seems to make an attempt to find the bank but then logs out and tries to switch to the next player (which doesn't exist.)

kor

2007-11-08 12:26:30

when im going to fish lobs it walks like to the yews or something then it starts laggin like hell..i have to stop it when i get there..

xxmynameisjohnxx

2007-11-17 22:12:22

Mmmm, downloaded, about to test, will post proggy tomorrow

Edit: nevermind, decided to use your mining guild script instead…:]

mschlott

2008-01-03 15:19:16

I used this script to go from a level 1 to a level 50 in one day. I fished shrimp and anchovies at dranor then trout and salmon at edgeville.

The walking to karmaja seems to hang up getting to the dock about half the time. I took that opportunity to learn more SCAR and SRL to "fix" the script. After 3 days of watching the script walk back and forth I determined walking is dificult.

Great Script.

munk

2008-03-28 01:30:24

as some may know/heard, i rewrote this script. and it is now posted :)

v.1.0.0
please post any feedback/bugs/proggies!

kingarabian

2008-03-28 04:22:33

And mark does it, the 1st person with perfect karamja fisher. Finally…

Running it now.

sir tien

2008-03-28 04:26:20

just a small problem might work if i run it second time, but i now get a message

'could not find watercolor' when i arrive at karamja. Fishing lobs, cooking true.

Any ideas? Testing again…

EDIT:

Ive tried to run it 3 times now, i'm using SMART but everytime i get the message Could not find Water Color and it stops the script after a couple of tries.

kingarabian

2008-03-28 05:06:22

From: sir tien
just a small problem might work if i run it second time, but i now get a message

'could not find watercolor' when i arrive at karamja. Fishing lobs, cooking true.

Any ideas? Testing again…

EDIT:

Ive tried to run it 3 times now, i'm using SMART but everytime i get the message Could not find Water Color and it stops the script after a couple of tries.


Yup, im getting the same problem here.

Also for alkharid, it walks to the fishing spot and everything, then it right clicks. After that It doesnt put net. It right clicks over and over again, but it wont click "net'.

dillbagz

2008-03-28 05:49:28

arrghh munk i now know why our eyes where on you great job…

EDIT: works perfectly untill it reaches karamja and gets off the ship then cannot find the water colour i think this is a bug as im the 3rd person to have this problem….

munk

2008-03-28 17:45:48

findWaterColor has been broken since the Easter update, i forgot because i fixed mine right away :) anyways, i forgot the only posted fix is in the members sections so here's mine so you can run my script :)


function FindWaterColor: Integer;
var
i,mx,my:integer;
begin
for i:=0 to 50 do
begin
if findColoredAreaTolerance(mx,my,12162685,mmx1,mmy1,mmx2,mmy2,50,i) then
begin
result:=getColor(mx,my);
writeln('watercolor = '+inttostr(result));
exit;
end;
end;
writeln('watercolor not found!');
end;
it has worked 100% for me, but idk. Just put that in your includes/srl/srl/core/autocolor.scar, and also next time you update your SRL through subversion you will have to do a cleanup or just delete your whole srl folder, otherwise you will get errors in your new version.

sir tien

2008-03-28 18:15:55

thx munk, testing right now!

EDIT:

Working great now, you can find me fishing my way up the next couple of days (A) thx a bunch

Becks

2008-03-28 23:42:14

everytime i run i get

Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!

is there a way i can set it to power fish in edgeville?

drizzt

2008-03-28 23:43:57

From: Becks
everytime i run i get

Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!
Could not find Water Color!

is there a way i can set it to power fish in edgeville?


read the post like, two above yours, and yea you can set it do do that, if you know how to script

nice script munk :D

kingarabian

2008-03-29 11:35:42

><>

4 Hours, 38 Minutes and 34 Seconds
113 Cooked Lobster

burnt 42 fish

<>< munk
the netting needs fixing. =/

Becks

2008-03-29 11:46:37

From: drizzt
read the post like, two above yours, and yea you can set it do do that, if you know how to script

nice script munk :D


haha thanks i wasn't paying attention when i posted.

kingarabian

2008-03-30 13:59:58

><>

3 Hours, 18 Minutes and 7 Seconds
61 Cooked Tuna
118 Cooked Lobster
30 Cooked Swordfish

burnt 51 fish

<>< munk

dillbagz

2008-04-02 04:04:33

i have 2 small bugs that i get

1) when he goes to click search away i have nothing to hide
2)on the walk to find the seamen

PvH

2008-04-02 06:22:21

i am making 3 players to lvl 50 fishing.. will take me about 5 days :p
if i got it.. you will get a karamja proggy from me:)
but you have to wait for it :p

EDIT;
tried it on my main
it walks to near that 4 willows at the beer shop

WaterColor = 12162941
wallColor = 15657711 took 32ms

than:

dock not found
dock not found
Rock Color = 4603718

status: finding seaman..
it is still near that beer shop.. so it won't find them
the other walking when i walk muanually to seaman, is great,, than it goes back and fares back to port sarim (when fished) and doesnt find the dock :(
you relaly need to fish that to make karamja fishing able:p
anyway.,. looks very nice except for that

kingarabian

2008-04-02 14:22:02

><>

4 Hours, 0 Minutes and 28 Seconds
14 Sardine
12 Herring
26 Lobster
10 Swordfish
75 Cooked Sardine
59 Cooked Herring
63 Cooked Lobster
27 Cooked Swordfish

burnt 46 fish

<>< munk

Heres mine, it ran smoothly.


Heres another:><>

5 Hours, 9 Minutes and 5 Seconds
50 Trout
28 Salmon
26 Lobster
236 Cooked Lobster

burnt 76 fish

<>< munk

munk

2008-04-03 17:36:02

From: pvh
i am making 3 players to lvl 50 fishing.. will take me about 5 days :p
if i got it.. you will get a karamja proggy from me:)
but you have to wait for it :p

EDIT;
tried it on my main
it walks to near that 4 willows at the beer shop

than:

status: finding seaman..
it is still near that beer shop.. so it won't find them
the other walking when i walk muanually to seaman, is great,, than it goes back and fares back to port sarim (when fished) and doesnt find the dock :(
you relaly need to fish that to make karamja fishing able:p
anyway.,. looks very nice except for that

reload client or change worlds. theres like 3 colors of the dock that it wont find. just watch the first run and if it finds dock, then itll run fine from then on.

From: kingarabian
><>

4 Hours, 0 Minutes and 28 Seconds
14 Sardine
12 Herring
26 Lobster
10 Swordfish
75 Cooked Sardine
59 Cooked Herring
63 Cooked Lobster
27 Cooked Swordfish

burnt 46 fish

<>< munk

Heres mine, it ran smoothly.


Heres another:><>

5 Hours, 9 Minutes and 5 Seconds
50 Trout
28 Salmon
26 Lobster
236 Cooked Lobster

burnt 76 fish

<>< munk


sardine and herring? woo, writing the baiting wasnt in veign!

dillbagz

2008-04-07 04:32:37

when can we expect a update on this script?

Pierre14

2008-04-07 05:57:07

an update would be Great!!! Munk really wanna use this script!!! Please update it to srl 15 when you have a chance!!!

Thank you, Pierre14

issamawan

2008-04-07 08:49:58

[0] olme = T | banked 1 | 26 fish | bank |

><>

19 Minutes and 34 Seconds
26 Cooked Lobster


<>< munk

just a quick test….works wonders…gr8 job…..

BUT!

plz plz plz add a bank pin to ur script dude….both my accounts have bank pin and im not willing to leave them…this goes toall ur scripts….esp the cooking one and this one

gr8 job

issamawan

effinpanda

2008-04-09 00:06:26

Does this work in catharby or fishing guild???

kingarabian

2008-04-09 00:47:58

From: effinpanda
Does this work in catharby or fishing guild???


Karamja
alkharid
edgeville

And maybe if munk's nice enough he will add more places. But he needs the proggies before anything.

munk

2008-04-09 02:35:51

From: effinpanda
Does this work in catharby or fishing guild???


please dont post and pm me the same question, and please use your eyes :rolleyes:


i posted an update. I dont remember what I did, but alot of tweaks and stuff. Also changes the pin from players.strings[3] to players.pin, #15 stuff. lets get some feedback people!

retybob

2008-04-10 14:57:46

runs very smooth for 2 trips then logs me out at bank and keeps clicking on the username/pass/loggin

kingarabian

2008-04-10 15:29:29

From: retybob
runs very smooth for 2 trips then logs me out at bank and keeps clicking on the username/pass/loggin


Set the rest of the other players to false if your using one player.

Munk heres another small proggie:
><>

3 Hours, 17 Minutes and 51 Seconds
26 Lobster
116 Cooked Trout
69 Cooked Salmon
74 Cooked Lobster

burnt 53 fish

<>< munk

Dan

2008-04-10 17:55:01

On net all it does for me is right click a few times, run to the next one right click on that one a few times and keeps repeating it :(

kingarabian

2008-04-10 18:19:12

From: Dan
On net all it does for me is right click a few times, run to the next one right click on that one a few times and keeps repeating it :(


Go to line 341 and change
'net'
to
'et'

Dan

2008-04-10 19:30:37

^ Thank you so much :).

igotgrapes

2008-04-10 20:16:00

hmm it only does one load and logs out.

i have the players set correctly, but i don't know how to increase the amount of loads.

kingarabian

2008-04-10 23:08:35

From: igotgrapes
hmm it only does one load and logs out.

i have the players set correctly, but i don't know how to increase the amount of loads.


In that case do this:

For net fishing go to the line 365
fishy.Mins := 10;
and change 10.

For /bait1 go to the line 397

For bait2 go to then line 425

For flyrod go to the line 459

For harpoon go to the line 487

For caging go to the line 510.

munk

2008-04-11 21:04:23

From: kingarabian
In that case do this:

For net fishing go to the line 365
fishy.Mins := 10;
and change 10.

For /bait1 go to the line 397

For bait2 go to then line 425

For flyrod go to the line 459

For harpoon go to the line 487

For caging go to the line 510.


ohhh! you got one wrong, azad:p I was about to just hand the thread over to you, haha. fishy.mins is just the max time it will stay at fishing spot. to change the time til it logouts, its like line 2660ish:

if timefrommark(s)>1200000 then

1200000ms = 20 minutes

idk if that fixes your problem, grapes, but if its logging out and then terminating, thats a problem. did you check status for a countdown til it logs back in?

kingarabian

2008-04-11 21:21:15

From: munk
ohhh! you got one wrong, azad:p I was about to just hand the thread over to you, haha. fishy.mins is just the max time it will stay at fishing spot. to change the time til it logouts, its like line 2660ish:

if timefrommark(s)>1200000 then

1200000ms = 20 minutes

idk if that fixes your problem, grapes, but if its logging out and then terminating, thats a problem. did you check status for a countdown til it logs back in?


ROFL!!!! No wonder why the script wont work right any more haha!

Thanks mark for the correction.

Edit: Oh yea btw the newest version doesnt withdraw the cash. And If you use this script with rev 15 it phails! Rev 14 is the way.

mynameisjoe

2008-04-13 16:49:35

I seem to get the error, "Could not find water color".. I'm fishing at Edge.. it doesnt move out of bank, just says cant find water color, and logs out.

t3hl33tn00b

2008-04-14 00:21:22

From: mynameisjoe
I seem to get the error, "Could not find water color".. I'm fishing at Edge.. it doesnt move out of bank, just says cant find water color, and logs out.


same problem for me, maybe runescape updated colors?

kingarabian

2008-04-15 15:47:53

From: t3hl33tn00b
same problem for me, maybe runescape updated colors?


{*******************************************************************************
function FindWaterColor: Integer;
By: Tarajunky
Description: Autodetects Water Color on Minimap
*******************************************************************************}

function FindWaterColor: Integer;
var
GC, a, l, TestColor, Red, Green, Blue : integer;
var
P:array of Tpoint;
begin
GC := 12095356;
Flag;
FindColorsSpiralTolerance(MMCX, MMCY, P, GC, MMX1, MMY1, MMX2, MMY2, 50);
l:=GetArrayLength(P);
for a:= 0 to l-1 do
begin
if rs_OnMinimap(P[a].x,P[a].y) then
begin
TestColor := GetColor(P[a].x,P[a].y);
if SimilarColors(TestColor,GC,50) then
begin
ColorToRGB(TestColor,Red,Green,Blue);
if InRange(Green - Red, 18, 30) then
if InRange(Blue - Red, 55, 72) then
if InRange(Blue - Green, 34, 52) then
if GetColor(P[a].x + 2, P[a].y + 2) = TestColor then
if GetColor(P[a].x + 1, P[a].y + 1) = TestColor then
if GetColor(P[a].x, P[a].y + 2) = TestColor then
if GetColor(P[a].x + 2, P[a].y) = TestColor then
if GetColor(P[a].x, P[a].y + 1) = TestColor then
if GetColor(P[a].x + 1, P[a].y) = TestColor then
if GetColor(P[a].x + 2, P[a].y + 1) = TestColor then
if GetColor(P[a].x + 1, P[a].y + 2) = TestColor then
begin
Result := TestColor;
WaterColor := TestColor;
WriteLn('WaterColor = ' + IntToStr(TestColor));
Exit;
end;
end;
end;
end;
WriteLn('Could not find Water Color!');
Result := 0;
end;
Thats how my findwatercolor; looks like? Maybe try Copy and pasting it.

And yea jagex is really messin with the water color, 2nd time so far.

Nava2

2008-04-15 20:50:02

Munk, if you are still kickin around, mind giving me a hand with my fisher? :(

Nava2

t3hl33tn00b

2008-04-16 22:17:37

From: kingarabian
{*******************************************************************************
function FindWaterColor: Integer;
By: Tarajunky
Description: Autodetects Water Color on Minimap
*******************************************************************************}

function FindWaterColor: Integer;
var
GC, a, l, TestColor, Red, Green, Blue : integer;
var
P:array of Tpoint;
begin
GC := 12095356;
Flag;
FindColorsSpiralTolerance(MMCX, MMCY, P, GC, MMX1, MMY1, MMX2, MMY2, 50);
l:=GetArrayLength(P);
for a:= 0 to l-1 do
begin
if rs_OnMinimap(P[a].x,P[a].y) then
begin
TestColor := GetColor(P[a].x,P[a].y);
if SimilarColors(TestColor,GC,50) then
begin
ColorToRGB(TestColor,Red,Green,Blue);
if InRange(Green - Red, 18, 30) then
if InRange(Blue - Red, 55, 72) then
if InRange(Blue - Green, 34, 52) then
if GetColor(P[a].x + 2, P[a].y + 2) = TestColor then
if GetColor(P[a].x + 1, P[a].y + 1) = TestColor then
if GetColor(P[a].x, P[a].y + 2) = TestColor then
if GetColor(P[a].x + 2, P[a].y) = TestColor then
if GetColor(P[a].x, P[a].y + 1) = TestColor then
if GetColor(P[a].x + 1, P[a].y) = TestColor then
if GetColor(P[a].x + 2, P[a].y + 1) = TestColor then
if GetColor(P[a].x + 1, P[a].y + 2) = TestColor then
begin
Result := TestColor;
WaterColor := TestColor;
WriteLn('WaterColor = ' + IntToStr(TestColor));
Exit;
end;
end;
end;
end;
WriteLn('Could not find Water Color!');
Result := 0;
end;
Thats how my findwatercolor; looks like? Maybe try Copy and pasting it.

And yea jagex is really messin with the water color, 2nd time so far.


that helped, it works now thanks :D

so far i have


><>

3 Hours, 6 Minutes and 55 Seconds
482 Trout
244 Salmon

found 6 whirlpools

<>< munk
and its still running

xentha

2008-04-17 06:28:59

Working well for me.

2 Hours, 44 Minutes and 50 Seconds
11 Salmon
221 Cooked Trout
146 Cooked Salmon

found 3 whirlpools
burnt 122 fish

munk

2008-04-17 21:20:36

thanks for using the script everybody! the stats are startin to go up a little :)

http://www.stats.srl-forums.com/index.php?action=view_script&id=367
all the vars line up so nicely on that page:D

well, if you have any questions, kingarabian will take care of ya, probably long before I read it:P

@nava2 - im around when im around. you got msn?

igotgrapes

2008-04-17 22:39:37

if this had a power fish option… u would be my hero haha. your forefeather's script has already gotten me a combined 1.7m exp over 4 characters.

Dr Feelgood

2008-04-18 12:12:49

For some reason it deposits the money when it's banking lobs at draynor other then that it has worked flawless for me.

kingarabian

2008-04-20 04:39:04

From: Dr Feelgood
For some reason it deposits the money when it's banking lobs at draynor other then that it has worked flawless for me.


Use rev 14, rev 15 is screwed.

issamawan

2008-04-20 08:28:20

hey kingarabian

tell me

ive got the rite watercolour…and it still says water colour not found

this happens no matter where i go

srl rev 14

wats happening bro?

ads_almighty

2008-04-20 11:25:43

37 Minutes and 49 Seconds
74 Cooked Trout
56 Cooked Salmon


First script that has work so well for me… I love you. heheh :P

[More progs.]

[0] [nick] = T | banked 15 | 416 fish | bank |

><>

1 Hours, 25 Minutes and 14 Seconds
253 Trout
163 Salmon

shrubie1

2008-04-21 05:45:11

this works alright but the walking could be bit more "flowing" and it takes a while to find the bank booth.

and when it banks it checks EVERY invent spot which is annoying AND detectable. try to fix it?

shrubie1

2008-04-21 06:00:39

yeh not working reall sik for me…

ads_almighty

2008-04-21 07:46:22

Its not up to him to fix your needs shrubie1. Learn some srl and make the walking movement better and whatever you want lol..

kingarabian

2008-04-21 15:11:03

From: issamawan
hey kingarabian

tell me

ive got the rite watercolour…and it still says water colour not found

this happens no matter where i go

srl rev 14

wats happening bro?


Update from 14-16. 15 is really buggy, 14, the auto coloring dont work, thats the reason it wont find the water color. So 16 should be good.

issamawan

2008-04-22 11:34:05

From: kingarabian
Update from 14-16. 15 is really buggy, 14, the auto coloring dont work, thats the reason it wont find the water color. So 16 should be good.


yea already started trying :p…thnx anyways

working so far

should get gud proggys,

issamawan

shrubie1

2008-04-23 11:13:53

From: ads_almighty
Its not up to him to fix your needs shrubie1. Learn some srl and make the walking movement better and whatever you want lol..


indeed i am learning the ways of the l33t and leaveing the path of the n00b in my trail… i am learning to script :stirthepot:

EDIT: oh i see… t'was updated for SRL rev 16… i shalleth try.
oh an btw do you think in the next update you could update the banking so it only clicks to deposit if there is anything otehr than rod and feathers in your invent? i would try to do it but im still a beginner at scripting.

d0pe b0i

2008-04-24 17:11:10

al kharid netting is bugged. just walks back and forth in between the fish spots

kingarabian

2008-04-24 17:45:47

From: d0pe b0i
al kharid netting is bugged. just walks back and forth in between the fish spots


Read the other previous posts….

scissormetimbers

2008-04-25 00:50:31

hey munk could you make the instructions in the script a little bit more in depth?

munk

2008-04-26 03:53:56

I updated the first post with some more info. Hopefully should help some people out. I'll post an updated version soon enough.

infested999

2008-05-12 15:05:43

Does the edgeville fishing work? Testing now…

shrubie1

2008-05-22 05:11:29

im testing edge fishing aswell so far it is fishing and we will see wat it does.

cant wait for update >.<

Shuttleu

2008-05-22 14:23:48

just been using this script for the last day and it works great
i changed the banking a little bit so that it wouldnt click on each spot
i would have a proggy for you but i sort of closed scar without copping the proggy by accident :s
the only problem i have now is that i can only get it to run for about 30 - 60 minuites before it stops for no reason

~shut

hamza

2009-02-17 13:52:15

program fishy;
{.include srl/srl.scar}

const
version = '1.0.0';

I think you forgot to change that bit where it says version = '1.0.0'; to 1.0.1 or you uploaded the wrong one.

When I tried it I got this message:
Line 2433: [Error] (18639:4): Unknown identifier 'amountDTM' in script C:\Users\hamza\…\fishy1.0.1[1].scar

jakeyboy29

2009-02-17 14:07:42

9 months gravedig? munk. we gonna close this?

Scaper

2009-02-19 19:38:56

From: hamza
program fishy;
{.include srl/srl.scar}

const
version = '1.0.0';

I think you forgot to change that bit where it says version = '1.0.0'; to 1.0.1 or you uploaded the wrong one.

When I tried it I got this message:
Line 2433: [Error] (18639:4): Unknown identifier 'amountDTM' in script C:\Users\hamza\…\fishy1.0.1[1].scar



dude this was posted in 2007 please look at the date before posting

also, look at the first and last posts andmaybe some before the last post before considering to post too

ZaSz

2009-02-19 20:47:41

From: Scaper
dude this was posted in 2007 please look at the date before posting

also, look at the first and last posts andmaybe some before the last post before considering to post too



Already pointed out by jakeyboy. Live by your rules, or don't preach them. :0

(i didn't have to say that but my postcount needs to rise.)

Hobbit

2009-02-19 21:36:27

Closed until author wishes to update