SRL Archive - Archive

<!– BEGIN TEMPLATE: formanswers –>
bet mtv - SRL Member Application Form
bet mtv

What is the meaning to life?to play runescape and script


Where you Referred to SRL? If yes, by whom?
no


Programming Knowledge
No

Other Communitys
none

How Long have You Played Runescape
7 years

Are you affilated in anyway with Jagex LTD?
No Comment
—————————————————–
Please write down a paragraph about Yourself.

hi my names bet mtv i have made 2 scripts and 1 was a program script were i made a log in script add it to hot key program and now i never type my user name or password since in in ne thing um i love runescape i love the macro programs..um i play on runescape/ computer / internet about 18 to 19 hours a day 5 days a week cuase i work.im going to fsu for computer security next year im 18 taking a break form life ….

——————————————————
Please Post a Sample of your Work. Only SCAR Scripts Accepted

{ ---------------------------------------------------------------------------- ]
[                         ..::   DESCRIPTION   ::..                            ]
[ ---------------------------------------------------------------------------- ]
[                    goes into fightcave and attacks till dies                 ]
[ ---------------------------------------------------------------------------- ]
[                       ..::   SUPPORTED SKILLS   ::..                         ]
[ ---------------------------------------------------------------------------- ]
[                               o  Strength                                    ]
[                               o  Attack                                      ]
[                               o  Defense                                     ]
[                               o  Balance                                     ]
[ ---------------------------------------------------------------------------- ]
[                      ..::   SETUP INSTRUCTIONS   ::..                        ]
[ ---------------------------------------------------------------------------- ]
[    o  Log out in front lava vent of fight cave                               ]
[    o  Fill in lines 42 through 46                                            ]
[    o  Set up characters on lines 63 through 85                               ]
[    o  Do not Change Anything in the Script Itself. Hit the Run Button Now!   ]
[    o  set camera veiw as low as posible pionting south                       ]
[ ---------------------------------------------------------------------------- ]
[[                               _____     _        _
   ______                      | ____ \  |_|   ___| |___
  / _____\    ____    _____    | \   \|   _   |___   ___|
 /  |        /  __\  /  __ \   | \   \|  | |      | |
 \  \____    | |    |  / __|   | \___\|  | |      | |
  \______\   |_|    |  \____   \______/  |_|      |_|       2   FOR HELP
                     \_____/
         SMARTZKID    AND   SEROKO


{.include SRL\SRL.Scar}
{.include SRL\SRL\Skill\Fighting.Scar}

var
  CaveColor: array[0..2] of Integer;
  SwitchMark, IntTime, i: Integer;
  CCFound: Boolean;
Const
  VerNumber = '1.0'; // Version Number
  iPlay = 5; // Minutes until switch player


{ ---------------------------------------------------------------------------- ]
[ Procedure DeclarePlayers - Declares Players.                                 ]
[ ---------------------------------------------------------------------------- }

Procedure DeclarePlayers;
Begin
  HowManyPlayers := 4;
  CurrentPlayer  := 0;
  NumberOfPlayers(HowManyPlayers);

  Players[0].Name     :='';
  Players[0].Pass     :='';
  Players[0].Nick     :='';
  Players[0].Integer1 := 2; //1 - 4 fightmode.
  Players[0].Active   := True;

  Players[1].Name     :='';
  Players[1].Pass     :='';
  Players[1].Nick     :='';
  Players[1].Integer1 := 1; //1 - 4 fightmode.
  Players[1].Active   := True;

  Players[2].Name     :='';
  Players[2].Pass     :='';
  Players[2].Nick     :='';
  Players[2].Integer1 := 1; //1 - 4 fightmode.
  Players[2].Active   := True;

  Players[3].Name     :='';
  Players[3].Pass     :='';
  Players[3].Nick     :='';
  Players[3].Integer1 := 1; //1 - 4 fightmode.
  Players[3].Active   := True;
end;

{ ---------------------------------------------------------------------------- ]
[ Function AttackType - Sets attack type.                                      ]
[ ---------------------------------------------------------------------------- }

Function AttackType : String;
Begin
  case Players[CurrentPlayer].Integer1 of
    1 : Result:= 'attack';
    2 : Result:= 'strength';
    3 : Result:= 'hitpoints';
    4 : Result:= 'defence';
  end;
end;

{ ---------------------------------------------------------------------------- ]
[ Procedure LoadScript - By: WhiteShadow                                       ]
[ ---------------------------------------------------------------------------- }

Procedure LoadScript;
Begin
  ClearDebug;
  SetUpSRL;
  DeclarePlayers;
  BenMouse:= True;
  MouseSpeed:= 7 + random(3);
  cavecolor[0]:= 6645101;
  cavecolor[1]:= 7829376;
  cavecolor[2]:= 8750479;
  if(not(LoggedIn)) then
    LoginPlayer;
End;


Begin
  LoadScript;
  repeat
    if(LoggedIn)then
    begin
      CCFound := false;
      for i := 0 to Length(CaveColor) - 1 do
        if(FindColorTolerance(x, y, cavecolor[i], MSX1, MSY1, MSX2, MSY2, 10))then
          CCFound := true

      if(CCFound)then
      Begin
        Mouse(x, y, 5, 5, true); //click on cavecolor
        //other stuff to do after cavecolor has been clicked
      end else
      begin
        Writeln('Could not find cave color');
        Logout;
      end;
    end else
    begin
      MouseSpeed:= 7 + random(3);
      NextPlayer(False);
      MarkTime(SwitchMark);
      SetFightMode(Players[CurrentPlayer].Integer1);
      SetRun(True);
      GameTab(4);
      HighestAngle;
      IntTime:= (iPlay * 60000) + random(5 * 60000);
    end;

    if(TimeFromMark(SwitchMark) > IntTime)then
    begin
      MouseSpeed:= 7 + random(3);
      NextPlayer(True);
      MarkTime(SwitchMark);
      SetFightMode(Players[CurrentPlayer].Integer1);
      SetRun(True);
      GameTab(4);
      HighestAngle;
      IntTime:= (iPlay * 60000) + random(5 * 60000);
    end;
  until(False)
End.

Please, use SCAR tags.

And, you forgot the programs name. That wouldnt compile.

a) You have no instructions in your script, and you tell nowhere what script is that, where to start and what colors to pick.

b) Standards. I put that through DF so I was able to read.

c) Pretty simple.

d) You have only variable declaring and setup in procedures. Everything else is in the mainloop. That makes the script hard to understand, easier would be, if you would use small procedures combined to big pack in the mainloop, with names that user (reader) would know of what does the script do.

c)

begin
Writeln('Could not find cave color');
Logout;
end;

That logs out like in the start - middle of the mainloop! That wouldnt be good for the scripts. One more reasons to use procedures and functions more. With them, you could put "if(not(LoggedIn))then Exit;" to every beginning of a procedure or a function, so, if the player gets logged out anywhere in the script, it will skip everything and change player.

Read some tutorials and apply again in a month.
That is a great beginning, and even you now will not get in, it is highly recommended that you apply again in a month.

Thanks.

Oh, the things that will get you in are likely:

* Failsafes.
* DTMs and/or bitmaps.
* RadialWalk or DDTMs
* Decent complex script.
* Im starting to forget.
* YoHoJo come here and tell the rest and close.
* Thanks.

{                               _____     _        _
   ______                      | ____ \  |_|   ___| |___
  / _____\    ____    _____    | \   \|   _   |___   ___|
 /  |        /  __\  /  __ \   | \   \|  | |      | |
 \  \____    | |    |  / __|   | \___\|  | |      | |
  \______\   |_|    |  \____   \______/  |_|      |_|       2   FOR HELP
                     \_____/
         SMARTZKID    AND   SEROKO and WhiteShadow}


{.include SRL\SRL.Scar}
{.include SRL\SRL\Skill\Fighting.Scar}

var
  CaveColor: array[0..2] of Integer;
  SwitchMark, IntTime, i: Integer;
  CCFound: Boolean;
Const
  VerNumber = '1.0'; // Version Number
  iPlay = 5; // Minutes until switch player


{ ---------------------------------------------------------------------------- ]
[ Procedure DeclarePlayers - Declares Players.                                 ]
[ ---------------------------------------------------------------------------- }

Procedure DeclarePlayers;
Begin
  HowManyPlayers := 4;
  CurrentPlayer  := 0;
  NumberOfPlayers(HowManyPlayers);

  Players[0].Name     :='';
  Players[0].Pass     :='';
  Players[0].Nick     :='';
  Players[0].Integer1 := 2; //1 - 4 fightmode.
  Players[0].Active   := True;

  Players[1].Name     :='';
  Players[1].Pass     :='';
  Players[1].Nick     :='';
  Players[1].Integer1 := 1; //1 - 4 fightmode.
  Players[1].Active   := True;

  Players[2].Name     :='';
  Players[2].Pass     :='';
  Players[2].Nick     :='';
  Players[2].Integer1 := 1; //1 - 4 fightmode.
  Players[2].Active   := True;

  Players[3].Name     :='';
  Players[3].Pass     :='';
  Players[3].Nick     :='';
  Players[3].Integer1 := 1; //1 - 4 fightmode.
  Players[3].Active   := True;
end;

{ ---------------------------------------------------------------------------- ]
[ Function AttackType - Sets attack type.                                      ]
[ ---------------------------------------------------------------------------- }

Function AttackType : String;
Begin
  case Players[CurrentPlayer].Integer1 of
    1 : Result:= 'attack';
    2 : Result:= 'strength';
    3 : Result:= 'hitpoints';
    4 : Result:= 'defence';
  end;
end;

{ ---------------------------------------------------------------------------- ]
[ Procedure LoadScript - By: WhiteShadow                                                    ]
[ ---------------------------------------------------------------------------- }

Procedure LoadScript;
Begin
  ClearDebug;
  SetUpSRL;
  DeclarePlayers;
  BenMouse:= True;
  MouseSpeed:= 7 + random(3);
  cavecolor[0]:= 6645101;
  cavecolor[1]:= 7829376;
  cavecolor[2]:= 8750479;
  if(not(LoggedIn)) then
    LoginPlayer;
End;


Begin
  LoadScript;
  repeat
    if(LoggedIn)then
    begin
      CCFound := false;
      for i := 0 to Length(CaveColor) - 1 do
        if(FindColorTolerance(x, y, cavecolor[i], MSX1, MSY1, MSX2, MSY2, 10))then
          CCFound := true

      if(CCFound)then
      Begin
        Mouse(x, y, 5, 5, true); //click on cavecolor
        //other stuff to do after cavecolor has been clicked
      end else
      begin
        Writeln('Could not find cave color');
        Logout;
      end;
    end else
    begin
      MouseSpeed:= 7 + random(3);
      NextPlayer(False);
      MarkTime(SwitchMark);
      SetFightMode(Players[CurrentPlayer].Integer1);
      SetRun(True);
      GameTab(4);
      HighestAngle;
      IntTime:= (iPlay * 60000) + random(5 * 60000);
    end;

    if(TimeFromMark(SwitchMark) > IntTime)then
    begin
      MouseSpeed:= 7 + random(3);
      NextPlayer(True);
      MarkTime(SwitchMark);
      SetFightMode(Players[CurrentPlayer].Integer1);
      SetRun(True);
      GameTab(4);
      HighestAngle;
      IntTime:= (iPlay * 60000) + random(5 * 60000);
    end;
  until(False)
End.

n3ss3s, re-examine the script execution flow, if the cavecolor isn't found, the next codeblock that gets executed will set the current player inactive and login on the next player.

bet mtv, you need to use [noparse]

 and 

[/noparse] tags, they preserve all your the formatting

By the way, you really should have told me you were going to try to apply with this script.

ok well i am sorry i will work on this stuf a little more and i will use this as a refrence for wat i should and should'nt do for my next time when i apply.Hmm i do thank you for u constructive critasism and help and like i said i will use this as a learning experience. :) and i think my instructions got lost ill have to try to find them cuz they were actually quite good i thought lol.srry bout the mis hap

http://www.villavu.com/forum/showthread.php?t=3562?p=39843#post39843

ok well i am sorry

You dont have to be sorry for making a script :D Relax

n3ss3s, re-examine the script execution flow

We never had this conversation, ok? Jk/Jk ;)

oh and the whole reason i didnt try to add any anti bans and things in that nature is,all its made to do is enter the fight cave and fight till u die as u know u dont get randoms in the fight cave.so i figured there really wasnt much to wory about.like i said im a use this as a learning expierence.!
ty for your time

I once used a cave fighter without antirandoms, and when it got out the cave, BOOM! Genie and banned.

I once used a autofighter without antiban or randoms (odies autofighter).. I was a nub to SCAR then and didn't know I shouldn't use that old scripts :p and when I checked I got 3 or 4 randoms in a row (just spawning in a row :p) and no ban :D So I guess you were unlucky to be banned after 1 genie …

Ok, back on topic…

The script is alright, but it's quite simple.. I won't vote, but I doubt you'll get in with that script, or you'll have to improve it quite alot.

ok so i get it i should add anti ban and anti randoms but does it mean i have to write it letter for letter word for word from scratch or is it ne consolation to use diffrent parts from diffrent ppls.and give credit but it proves i still know hoe to inquire it into my scripts..:D

oh i dont mean to spam with this but did u like the instructions i found out i didnt copy and paste the whole thing from the scar lol oops..but ne ways did u like it was it looking ok

its overall just way too short and missing two KEY things you need:
Antiban and Antirandoms.
Also, please dont double posts.
I say hang around the forum more and learn more by reading tutorials and talking to others.

Its going to be a NO for now, better luck next time, and remember, you must wait AT LEAST one moth before applying again.