SRL Archive - Senior News and General

This is 50% complaint, 50% information, and 100% confused.

If you've noticed, there's a new include on the scar include list. This 'PH' include is 747 lines long and is made by someone known as The Guy Who Got On, or TGWGO.

My first observations upon skimming this include:

-He doesn't know how to use case

    number:= getscarversion
    if number = 301 then version:= 'Divi 3.01'
    if number = 302 then version:= 'Divi 3.02'
    if number = 303 then version:= 'Divi 3.03'
    if number = 304 then version:= 'Divi 3.04'
    if number = 305 then version:= 'Divi 3.05'
    if number = 306 then version:= 'Divi 3.06'
    if number = 310 then version:= 'Divi 3.10'
    if number = 311 then version:= 'Divi 3.11'
    if number = 203 then version:= '2.03'

-No descriptions

  procedure mbox(xx, yy, xx2, yy2: integer);
  procedure playfish;
{...}

-Bad standards

    {lack of semicolons}
    if scriptname = 'TGWGOcpautofisher' then safe:= true
    if scriptname = 'TGWGOautotalker' then safe:= true
    if scriptname = 'TGWGOchickenSlayer' then safe:= true

  {Varying indents (some indented, some not)}
  procedure validate;
procedure slowmcbox(xx, yy, xx2, yy2: integer; lefft: boolean);

-Part RS, part Gaia?

//Gaia

=> No distinct divide between Gaia and RS?

-Other things, like this, which I am still wondering about:

    procedure kewl;
    var i: integer;
    begin
      if fade = true then
      begin
        for i := 255 downto 0 do
        begin
          i:= i - fadespeed
          MakeWindowTransparent(GetSelf.Handle, i);
        end;
        wait(waittime);
        for i := 0 to 255 do
        begin
          i:= i + fadespeed
          MakeWindowTransparent(GetSelf.Handle, i);
        end;
      end;
    end;

=>Now what's the point of that? Make the person wait while scar fades in and out again?

I'll post some more if I need to, but really, how's something like this get up there, and dp's include not? (not that either are needed…)

Oh, another thing: There's 11 members at planethell. Why can't they just put this into their include folders if they want to have their own include?

I wrote a small piece of code for him to quickly parse the version, but he preffered it his way…
As for the rest, well the previous includes in SCAR weren't all structurised either, so…
Anyone who wants can get their include uploaded if they think it's worth it…

i r making an include that rapes SRL to death!

lol no way