SRL Archive - First Scripts

[release]Herblore Master[firstscript]


goodgamescript

2015-05-05 19:01:42

~Herblore Master~

[LEFT]Features[/LEFT]
.Banks At All Supported Locations
.Anti Ban
.Break System
.Makes All Potions
.Cleans All Herbs
.Uses Quick Presets
.Fail-safes
.Prodigy System
.Added Stats by Grats!

[LEFT]Setup[/LEFT]
.Be sure to have your quick load layout on old school , action bar minimize,and the xp counter in the correct spot.
.Fill out lines 7 - 14 to set up the bank,camera angle,bankpin,break handler, and antiban.
.Set preset 1 for herbs and preset 2 for making potions.
Preset 1
[ATTACH=CONFIG]25814[/ATTACH]
Preset 2
Have Primary Item in the first 14 slots.
[ATTACH=CONFIG]25815[/ATTACH]
.Put the xp counter here.
[ATTACH=CONFIG]25817[/ATTACH]
.Hit the play button and fill out the form.

[LEFT]Doesn't Have[/LEFT]
.Profit Calc
.Familiar support
[LEFT]Progress Reports[/LEFT]
You have made runs 681 out of 900 and have Made 9520 Unfs Your script stopped because Out of supplies And Total Breaks 3 and ran for 7 hr 30 min 23 sec

You have made runs 286 out of 900 and have Cleaned 7980 Herbs Your script stopped because Out of supplies And Total Breaks 1 and ran for 2 hr 56 min 31 sec

This was before i updated the prodigy to smart.

Progress report by nero_dante

[LEFT]Bugs[/LEFT]
.sometimes the xp gained bugs out just restart the script.
.Very rarely drinks potions maybe 1/1500 hopfully fixed in V1b
.overload potions bugged , hopefully fixed in v1.a - fixed

[LEFT]Overload Setup[/LEFT]
Have items in Preset 2, the first 8 of them are the Clean torstol the rest are the 4 of each of the extreme potions.
[ATTACH=CONFIG]26115[/ATTACH]


[LEFT]99's With this script[/LEFT]
nero_dante

Please Post any ideas on how to improve the code, or what could be added.

Fr3akNL

2015-05-05 19:20:32

Hey man grats on ur first script. Might check this out tomorrow.
Do you have any proggies yet?

goodgamescript

2015-05-05 19:37:11

From: Fr3akNL
Hey man grats on ur first script. Might check this out tomorrow.
Do you have any proggies yet?


Added some.

Thomas

2015-05-06 09:40:54

Good job on the release!
I think the script has quite a bit of unneeded code currently though. I have a similar script in the junior member section and it is around 200 lines.

Example is this code:
  repeat
wait(randomrange(300, 500));
until (bankScreen.isOpen());

This loop has no exit, what if the script logs out? Also the bankScreen.isOpen() has a max time integer, so it's rather useless to repeat that wait.
You could just use 'bankScreen.isOpen(randomRange(5000,10000));'


I recommened having a quick glance at my tutorial:
https://villavu.com/forum/showthread.php?t=112779

It should help you clean up your code I'm sure.
If you want I'll also PM you the latest version of my script in the jr section.

goodgamescript

2015-05-06 11:55:27

Thanks for the tip =D and sure you can pm me it, i will look at how the code is written and learn from it=D

Thomas

2015-05-07 04:17:26

From: goodgamescript
Thanks for the tip =D and sure you can pm me it, i will look at how the code is written and learn from it=D


Sent you a PM. I have been running the script for over 1k hours so far I think. Only thing I don't like is how I repeat the antiban as sometimes it can postpone the banking for new items.

OP in the Jr section:

Hey,

This script could be used for making potions, combining battlestaffs, making wines,…
Start at at any SRL supported bank, the script banks using preset 1.
Have preset 1 setup so you have 1 of each item in slot 1 and 2 because it combines slot 1 on slot 2.
It will repeat the antiban untill no item in slot 27 (this allows for faster restocking of items), so make sure the last slots will be cleared from items. (Mainly important if combining potions with scroll of cleansing).

Example:
[ATTACH=CONFIG]25718[/ATTACH]

Keeping this in the junior section untill I receive more feedback and bugs.

goodgamescript

2015-05-07 12:07:36

From: lovebotter
Sent you a PM. I have been running the script for over 1k hours so far I think. Only thing I don't like is how I repeat the antiban as sometimes it can postpone the banking for new items.

OP in the Jr section:

Hey,

This script could be used for making potions, combining battlestaffs, making wines,…
Start at at any SRL supported bank, the script banks using preset 1.
Have preset 1 setup so you have 1 of each item in slot 1 and 2 because it combines slot 1 on slot 2.
It will repeat the antiban untill no item in slot 27 (this allows for faster restocking of items), so make sure the last slots will be cleared from items. (Mainly important if combining potions with scroll of cleansing).

Example:
[ATTACH=CONFIG]25718[/ATTACH]

Keeping this in the junior section untill I receive more feedback and bugs.


i notice in your combine script that it has very few anitbans, does that really matter in a non-walking type of script?

Thomas

2015-05-07 12:15:36

From: goodgamescript
i notice in your combine script that it has very few anitbans, does that really matter in a non-walking type of script?


I've ran the script over 1k hours. I don't think it matters much, feel free to add more antiban if you please.

goodgamescript

2015-05-07 12:29:28

Im shorting the code on my script a bit, i have like over 50 lines of anti-ban i can remove then.

Thomas

2015-05-07 12:49:58

From: goodgamescript
Im shorting the code on my script a bit, i have like over 50 lines of anti-ban i can remove then.


I wouldn't remove the antiban if it doesn't bother you.

goodgamescript

2015-05-07 12:59:49

True does fastClick() always click at the same rate or should i be using it at all?

Thomas

2015-05-07 13:05:46

From: goodgamescript
True does fastClick() always click at the same rate or should i be using it at all?



(*
fastClick
~~~~~~~~~

.. code-block:: pascal

procedure fastClick(button: integer);

Quickly click the mouse with any button.

.. note::

- by Flight

Example:

.. code-block:: pascal

fastClick(MOUSE_LEFT);

*)
procedure fastClick(button: integer);
var
x, y: integer;
begin
if (button = MOUSE_MOVE) then
Exit;

getMousePos(x, y);
holdMouse(x, y, button);

wait(randomRange(60, 150));

getMousePos(x, y);
releaseMouse(x, y, button);
end;
So it holds click down a little random yes.

nero_dante

2015-06-04 23:15:58

hey how did u get the overload making to work?

goodgamescript

2015-06-08 19:28:54

sorry for the late response, and does it work lol i don't have the required herblore lvl to do em so the timing might be off a little. I notice a couple of bugs and is should be releasing another version with in the next week or so.

nero_dante

2015-06-09 21:45:28

From: goodgamescript
sorry for the late response, and does it work lol i don't have the required herblore lvl to do em so the timing might be off a little. I notice a couple of bugs and is should be releasing another version with in the next week or so.


Well, the bot will bring out the items to start making the overloads, but then it doesnt try and put them all together, just stands there.

goodgamescript

2015-06-10 01:04:03

From: nero_dante
Well, the bot will bring out the items to start making the overloads, but then it doesnt try and put them all together, just stands there.


Alright try this new version and follow the overload setup and when you make overloads you do get the production screen?

nero_dante

2015-06-10 09:35:29

From: goodgamescript
Alright try this new version and follow the overload setup and when you make overloads you do get the production screen?


I'll try it out when i get back home from work :)

goodgamescript

2015-06-12 22:14:38

From: nero_dante
I'll try it out when i get back home from work :)


Everything work ok?

nero_dante

2015-06-13 15:31:46

From: goodgamescript
Everything work ok?


I been doing so many quests haven't gotten round to checking. I'll probably check it later on tonight :)

nero_dante

2015-06-13 17:27:20

From: goodgamescript
Everything work ok?


yeah using now and with the preset that you told me to set it works :) I'll see if it runs for however long. I got 4k overloads to make :P

nero_dante

2015-06-13 18:28:38

lasted an hour then randomly stopped doing anything even though the script is still running lol

https://gyazo.com/9b1041caddf900214bbd249aa804393e


EDIT: I left it for a few minutes and then it just started working again haha xD

nero_dante

2015-06-13 18:30:48

that screenshot is nice as well lets people see that the script can get you about 1m/hr xp which is not bad. about 800 pots hour i think it is

goodgamescript

2015-06-13 18:40:44

From: nero_dante
lasted an hour then randomly stopped doing anything even though the script is still running lol

https://gyazo.com/9b1041caddf900214bbd249aa804393e


EDIT: I left it for a few minutes and then it just started working again haha xD


lol idk maybe it just took a long break there is a couple times will it wait for a little bit and thanks for the testing =D

nero_dante

2015-06-13 18:43:30

From: goodgamescript
lol idk maybe it just took a long break there is a couple times will it wait for a little bit and thanks for the testing =D


np, I'm going bed now and I'll just leave it on because fuck it xD lool. Hopefully it will do the other 3k torstols and get me 99 herblore over night :P

goodgamescript

2015-06-13 18:45:59

Hopefully it works out lol

nero_dante

2015-06-13 19:16:44

From: goodgamescript
Hopefully it works out lol


internet cut for like 5 minutes ¬_¬ for some reason. but i have put it back on and i have 2.6k overloads left to make. I'll update you in the morning :) Great script again

nero_dante

2015-06-14 00:45:36

hey just woke up randomly, and it seems the script can only run for about an hour max and then something goes wrong. However, it may possible be because im in world 2 burthorpe so its very laggy. However it did get me the 99 herblore lol. just gunna do the last 1.8k overloads and hopefully it does them without needing to break :)

nero_dante

2015-06-14 02:30:55

Small bug i noticed, is that while i was watchign a film for 30minutes it tried to use a torstol on an empty vial which the script must have accidently drank. Perhaps putting in a fail safe where if the script hovers over an empty vial it should rebank, or it should go to another bag slot to make the potions. I think rebanking is the safer option

goodgamescript

2015-06-14 12:21:54

From: nero_dante
hey just woke up randomly, and it seems the script can only run for about an hour max and then something goes wrong. However, it may possible be because im in world 2 burthorpe so its very laggy. However it did get me the 99 herblore lol. just gunna do the last 1.8k overloads and hopefully it does them without needing to break :)


it could be hmmm did the script stop or was it still running, because there is only a couple times where the script will terminate, if the bag isnt full ,
it searches for the bank 3 times and doesn't find it,
or the mouse text is wrong,
but im thinking if there was lag maybe it couldnt find the bank i will have to test it at a laggy location.

goodgamescript

2015-06-14 12:29:51

From: nero_dante
Small bug i noticed, is that while i was watchign a film for 30minutes it tried to use a torstol on an empty vial which the script must have accidently drank. Perhaps putting in a fail safe where if the script hovers over an empty vial it should rebank, or it should go to another bag slot to make the potions. I think rebanking is the safer option


im thinking it just missed click the herb,might have been do to lagg, then drank a dose when trying to use the herb on it so i could just make sure the herb slot is active before using it on the secondary item. so it doesnt drink it.

goodgamescript

2015-06-14 12:52:31

From: goodgamescript
im thinking it just missed click the herb,might have been do to lagg, then drank a dose when trying to use the herb on it so i could just make sure the herb slot is active before using it on the secondary item. so it doesnt drink it.


Added the above fix hopefully that does it, but it doesnt let me know and i will go about it the long way lol, that was only like 3 lines of code.

nero_dante

2015-06-14 16:02:07

From: goodgamescript
it could be hmmm did the script stop or was it still running, because there is only a couple times where the script will terminate, if the bag isnt full ,
it searches for the bank 3 times and doesn't find it,
or the mouse text is wrong,
but im thinking if there was lag maybe it couldnt find the bank i will have to test it at a laggy location.


laggiest location is burthorpe world 2 lol, plusbthere is always a well there ;) Also i wont be able to do any more testing with overloads, because thescript did end up doing them all in the end :P

goodgamescript

2015-06-14 20:45:16

From: nero_dante
laggiest location is burthorpe world 2 lol, plusbthere is always a well there ;) Also i wont be able to do any more testing with overloads, because thescript did end up doing them all in the end :P


fair enough lol grats on 99 herblore!

nero_dante

2015-06-15 07:16:16

From: goodgamescript
fair enough lol grats on 99 herblore!


Thanks, you can put 99 achieved in your 1st post as well ;). Cause I used this script since level I believe 92

goodgamescript

2015-06-18 15:54:57

Added Stats by Grats!