SRL Archive - First Scripts

[F2P][RS3] Torol's Taverley Autobuyer


Torol

2014-11-16 11:05:27


Description:
So, I just released the 2nd version of this script. It can buy more things now from the cooking supplies shop. I rewrote the whole thing from scratch. I just left a few methods in it. Actually, it's not more profitable than the previous one, but it's certainly more complicated.. :D I would be very grateful for feedbacks, bug/weird behaviour reports, since it can be buggy.

Setup:
  • Put the SPS map (TAVERLEY.png) in the "Simba\Includes\SPS\img\runescape_other" folder!
Requirements:
  • Make sure you have enough money in your pouch!
  • Place your character in the Taverley bank, tavern, or on the route between!
  • Start the script with an empty inventory.


Credits:
  • The Mayor, Camel: scripting tutorials, guides
  • Turpinator, and other IRC dwellers for coding help
  • The whole supporting SRL community!
Thanks for reading! ^-^
Feedbacks, bug reports and proggies are much appreciated!
Torol

Kyle

2014-11-16 11:12:57

Nice job and congrats on your first release! As something to think of for a later option you could add world hopping in order to buy more than the shop allows, unless Rs3 is different than how it used to be/like OSR. Once again though, great looking script!

Torol

2014-11-16 11:21:23

From: elfyyy
Nice job and congrats on your first release! As something to think of for a later option you could add world hopping in order to buy more than the shop allows, unless Rs3 is different than how it used to be/like OSR. Once again though, great looking script!



Thanks! Yes, it's different, unfortunately they changed that.

KeepBotting

2014-11-16 11:22:14

From: elfyyy
Nice job and congrats on your first release! As something to think of for a later option you could add world hopping in order to buy more than the shop allows, unless Rs3 is different than how it used to be/like OSR. Once again though, great looking script!


Yeah, RS3 shop stock is global now. hopping worlds doesn't do anything since shop stock is per-account, not per-world

OT gratz on the release!

Lipcot

2014-11-16 13:39:09

Gratz on release! i had thought of doing a bot for these kind of runs just yesterday ! lolss

Torol

2014-11-16 14:48:33

From: KeepBotting

OT gratz on the release!

From: undorak7
Gratz on release! i had thought of doing a bot for these kind of runs just yesterday ! lolss


Thanks! :)
undorak7, yeah, the original goal was a whole daily shop run, but i have to begin somewhere… :D

Torol

2014-11-24 11:42:50

I already made the 2nd version, but it's not stable enough yet. Can I pm to someone for help?

Incurable

2014-11-24 11:46:15

From: Torol
I already made the 2nd version, but it's not stable enough yet. Can I pm to someone for help?


Post here: https://villavu.com/forum/forumdisplay.php?f=646

Or PM me if you really want to keep your question private for some reason.

Torol

2014-11-24 12:00:01

From: Incurable
Post here: https://villavu.com/forum/forumdisplay.php?f=646

Or PM me if you really want to keep your question private for some reason.


Thanks! I will release this, I'm not developing a private script, but I have a lot of questions, and I don't want to spam that section with every detail. Moreover it's a faster way to get help :) I will explain my problems in pm soon!

Incurable

2014-11-24 12:46:13

From: Torol
Thanks! I will release this, I'm not developing a private script, but I have a lot of questions, and I don't want to spam that section with every detail. Moreover it's a faster way to get help :) I will explain my problems in pm soon!


Never be afraid to ask questions, and don't be afraid to ask multiple questions in one thread. :)

Torol

2014-11-24 14:03:21

Okay, I think I'll just upload it here, and then I'll fix the bugs, and update it.

Rlp

2014-11-24 14:05:31

From: Torol
Thanks! I will release this, I'm not developing a private script, but I have a lot of questions, and I don't want to spam that section with every detail. Moreover it's a faster way to get help :) I will explain my problems in pm soon!


I don't know about a faster way to get help, if you post public to the forum you have a lot more people able to help you, which surely has to be faster than 1 person by pm.

Hope you get the help you need, don't be afraid to ask all the questions you need :) You will find most people on here are friendly.

Torol

2014-11-24 14:25:00

Thanks! I just uploaded the file. My original goal was to create a script, which can be used to every shop with some simple modifying. I still have got to work a lot on this goal.. but I think I'm on the right path :)

zeinir

2015-01-04 05:31:00

// Loads done: 1                                          //
////////////////////////////////////////////////////////////
-- TPlayer.logout()
happens every time? buys a load and banks its perfectly, then logs out and stops the script.

bonsai

2015-01-04 06:32:12

From: zeinir
// Loads done: 1                                          //
////////////////////////////////////////////////////////////
-- TPlayer.logout()
happens every time? buys a load and banks its perfectly, then logs out and stops the script.


I'm going to suggest commenting out lines 636/637

@Torol, this script is really coming along. I like the thought process I see going into it and that you are using more than just the basic ABCs.

I suggest you think about how to get the detailed data like product names, DTMS, etc, into a data file that the script reads. This will make your code simpler, more generic, and easier to play with over time.

Also, if you do a bitmapfromstring() or dtmfromstring() you are allocating memory inside simba. You need to do a freebitmap() or freedtm() to free them up.

You'll notice most people initialize things like this as globals and free them up at script termination time.

Many people get away with being sloppy on that since there are so few. But the way you did it, it creates a new one every time the function gets called so they could add up significantly over time.

zeinir

2015-01-05 07:52:20

From: bonsai
I'm going to suggest commenting out lines 636/637
Thanks, fixed the first problem, but now it won't detect the pot of flour or the cups of water. The whole item isn't in frame I guess? And every 15 or so loads it won't detect the bank. excepting that I love this script.

Torol

2015-01-05 12:13:43

Sorry guys, the script is pretty much broken, and I won't update it in the near future. It didn't have much technical use anyway, it was just a little experiment of mine. Thanks for the advice @bonsai maybe when I start rs again I'll do as you said.