SRL Archive - Archive

PatriqDesigns - SRL Member Application


Patriq

2014-07-26 18:03:41

How Long have You Played Runescape?
6 Year(s)


Are you affilated in anyway with Jagex LTD?
No

Were you Referred to SRL?
KeepBotting


What is your general programming knowledge?
Java, PHP, Pascal, and learning JavaScript.
I know a bit of HTML and CSS too..


Are you a member of any other communities?
Powerbot


Tell us about yourself…
From: PatriqDesigns
Well Im just a young 17 year old boy which as programming as a hobbie and he wants to let that hobbie grow so it can be his future carrer. I do like soccer, and play team games like LoL and Shooters.



Please show us one (or multiple) of your scripts.
EdgeSmelter
- http://paste.themayor.tk/?b259897e94614a47#LYEcnx21JHKYodOX8USNeZshgp9AiBn2lISthRx9WO0=

UnfMaker
- http://paste.themayor.tk/?ae5c6f7775901029#p8O0A+f+AbFVAfl8D515RGQugyYGScbhRFFabe1On2Q=

My very first script - IronPowerMiner
- http://paste.themayor.tk/?297f066260cdc408#RX9gRGx0H8V3MBjfeMSZOguS7cAmteDLIvpImEmZ2mY=

PinopFletcher
- http://paste.themayor.tk/?1262120f60b2d672#2OlBP3Fr0elsmQKa01GX0dZszQ4ghABuFrX+4ARTnYE=

PinopIvy
- http://paste.themayor.tk/?7b68cad1a8566267#ILM3rVicrOhAO1jt+yY75whKe134BA3BDSsJwmzoFOM=

Forgot my best script. Oppss.
http://paste.themayor.tk/?64173a2fe3da396f#IpZNRqnC58/Trz3ZbsTN9Z62rR+8vYiIy3En1hZVudM=

Wetish

2014-07-26 18:23:51

This rank is based on scripting ability and community activity. About one month of activity with 18 posts isn't going to cut it. I voted no.

Sin

2014-07-26 18:24:50

You used Mayor's paste… LOL expect a yes from him.

Patriq

2014-07-26 18:32:08

Well I couldnt add attachments, I dont know why so it was my only solution! :P

From: Wetish
This rank is based on scripting ability and community activity. About one month of activity with 18 posts isn't going to cut it. I voted no.


As for that, I know I created the account a long time ago, but I just got into developing a few days ago, of course Pascal developing.
Well anyways Im aware Im not part of the community yet, but if that is my only problem and if the scripts are acctually good please tell me.

I want some reviews about the script because thats what matters in my opinion, I want some pointers some lines, some what to do and what not to do, because I got 2 No and 1 is for not being active which I undersand, and the other I just feel like it was just threw away randomly :P

Thank you very much all.. :)

Wetish

2014-07-26 19:01:07

A great way to get feedback and increase your activity is to release your scripts for others to use.

As for actual feedback, your fungus script is good. You have good conventions. I liked the functions you made for finding objects with atpas. It really made it easy to read. I'm not familiar with srl6 so I can't really comment on your use of the include.

When moving the mouse to positions it is a good idea to add randomness.
Instead of clicking the same pixel on the found dtm every time
if(findDtm(renewalDtms[i], x, y, bankScreen.getBounds)) then
mouse(point(x, y), MOUSE_LEFT, MOUSE_HUMAN);
you could add a bit of randomness. This applies to when you move the mouse to tpas too.
if(findDtm(renewalDtms[i], x, y, bankScreen.getBounds)) then
mouse(point(x + randomRange(-5,5), y + randomRange(-5,5)), MOUSE_LEFT, MOUSE_HUMAN);
RandomRange may not be a function in srl6 but you get the idea.

You could simplify some things but this is really nitpicky and you shouldn't worry about it.
 if (not dontWithdraw) then
instead of
 if(dontWithdraw = false) then

The Mayor

2014-07-26 19:01:08

From: Sin
You used Mayor's paste… LOL expect a yes from him.


:p


SRL Members are lazy as f, so you should actually display your script in your post. Just throw it in simba tags [.SIMBA] [./SIMBA]. Personally I don't like reading 10 different scripts, I like reading just 1. You should be able to demonstrate your scripting ability and knowledge in 1 script. I would pick your best one and use that.


Anyway, from a quick look the scripts are well written, but as other said the big let down is your activity. Some members feel that your contribution to the community is even more important than your scripting ability. To me it looks like you've just come from PB and want access to the higher boards :) I would release some of your scripts public, help other users, and just be more active in general.



EDIT: How did you apply? Isn't the application button in the junior section?

Patriq

2014-07-26 19:23:25

Were you Referred to SRL?
KeepBotting

He gave me the link :)

NKN

2014-07-26 21:01:08

I'm going to have to vote no. The scripts are nice, some things you could clean up, but the activity just isn't there.

Wu-Tang Clan

2014-07-26 22:34:40

Well the edgesmelter would have been nice to know about before I spent a few hours making my own… by the looks of it you've got some things you need to work on, and your post count needs to be a bit higher. I'm going to vote no but if you reapply with significant changes you can expect a yes from me

EDIT: NVM I voted yes by accident but then decided it's for the best.
You used a TPA and had a decent looking banking function that wasn't consisting of only "include functions". I'm lazy and occasionally rely on the include but you went above and beyond here. Good luck on your application and if this one doesn't work out I bet the next will get you members status.

God bless man

Patriq

2014-07-27 03:29:14

Thank you all :)

masterBB

2014-07-27 03:57:46

Closed.

I agree with the others. You can reapply in two weeks, but I suggest to wait a bit longer. Get to know the community a bit.

Have a nice day.