SRL Archive - Jr. Member RS3 Outdated Scripts

This script crafts air runes and teleports back to varock. It is currently in an alpha stage. Below is a quick run which I have just completed (on a FTP account with 99RC)

Time Run: 21 Minutes and 55 Seconds
Loads Done: 21
Profit Made: 125580
Per Hour: 343740
========================================================

EDIT: Cleaned up the script and I have uploaded he new version. It now includes SPS and bitmap walking. I will update this post with the SPS maps etc soon

Not bad for a few hours work. SPS can be OK if you get your map right and have sufficient failsafes. A few things I noticed:

This:

Mouse(200,575,5,5); // Clicks the Quickload button

Can be:

bankScreen.clickButton(BANK_BUTTON_PRESET_1);

And things like this are pretty hard to read and understand what's happening:

  if (not bankScreen.isOpen()) then begin printStatus('QuickLoad Suceeded',2); Result := True; // Checks if the bank is closed again
    end else begin printStatus('QuickLoad Failed',4); Result := False; // If not it prints an error and returns false 

Much better to keep it like so:

if (not bankScreen.isOpen()) then
begin
  printStatus('QuickLoad Suceeded',2);
  Result := True; // Checks if the bank is closed again
end else
begin
  printStatus('QuickLoad Failed',4);
  Result := False; // If not it prints an error and returns false
end; 

Some unnecessary code, such as using the old FindColorsSpiralTolerance where you set the CTS modifiers first and then change them back afterwards. Just use the overload function with the colorSettings (which you've used further down).

Thanks, I will get around to fixing it up and making it more neat. I do not think the debug system which I used initially is fully implemented. Having a quick read it seems I am not the only one having problems with SPS https://villavu.com/forum/showthread.php?t=109377. When grabbing two images from the minimap they seem to be distorted slightly (different sections do not line up at all and they seem to be rotated slightly at different angles). I seemed to be getting 'Not enough matches found to accurately calculate your position' errors. At the moment bitmap walking seems stable enough- I just need to add some fail-safes.

Are you using someone else's SPS map "varcen?" Could you please link to it if so, otherwise do you mind uploading it?

Some feedback:
BMP walking always walks to the NE of the bank before coming back inside, often making it target the northeastern-most banker in the locked room, at which point it gets stuck.

Maybe try choosing a bitmap (or two!) that do not rely on the bank's MM icon? Since that icon moves around so much.

edit: nvm, after watching it a bit longer, it appears it is using bitmaps other than the bank logo. Not sure why it's running circles around the bank so much :p. I may try tweaking tolerances and bitmaps.

^My bad, I have been busy making a couple of private scripts. I will get around to updating this sometime today