From: Brandon
I mixed up the try except with try finally. Nothing should be wrong there. However, the try except wouldn't be necessary for the string copy and as you mentioned, you removed it.
I really cannot see anything else that would leak. What does the other code look like? This function itself looks fine. Are you absolutely positive it is this function and only this function that is leaking?
Yes, absolutely sure. Figured out that the bigger the file that it reads gets, the more it leaks. So it must have something to do with that? I can't notice an increase with a 1kb file but with a 800kb file it is very noticeable.
E: here is the whole file… I am calling TLog.check() and have ran a test script that ONLY calls it and results in the leak.
{$include_once srlutilities\srlutilities.simba}
// By Janilabo
{==============================================================================]
Explodes str with multiple separators/delimiters (d).
The importance order for d items is from left to right (=>).
So place the important ones first and then less important after those.
[==============================================================================}
function StrExplodeMulti(d: TStringArray; str: string): TStringArray;
var
a, b, i, l, p, r, s, z, g: Integer;
m: Boolean;
begin
SetLength(Result, 1);
l := Length(str);
s := Length(d);
if ((l > 0) and (s > 0)) then
begin
r := 0;
z := 0;
for a := 0 to (s - 1) do
begin
p := Length(d[a]);
if (p > 0) then
if (p <= l) then
begin
if (z = 0) then
z := Length(d[a])
else
if (Length(d[a]) < z) then
z := Length(d[a]);
d[r] := d[a];
Inc(r);
end;
end;
if (r > 0) then
begin
s := r;
a := 1;
p := 1;
r := 0;
while ((a + (z - 1)) <= l) do
begin
m := False;
for i := 0 to (s - 1) do
begin
g := Length(d[i]);
if ((a + (g - 1)) <= l) then
begin
for b := 1 to g do
begin
m := (str[((a + b) - 1)] = d[i][b]);
if not m then
Break;
end;
if m then
Break;
end;
end;
if m then
begin
Result[r] := Copy(str, p, (a - p));
if ((a + (g + 1)) = l) then
Exit;
p := (a + g);
a := ((a + g) - 1);
Inc(r);
SetLength(Result, (r + 1));
end;
Inc(a);
end;
Result[r] := Copy(str, p, ((l - p) + 1));
end else
Result[0] := '';
end else
Result[0] := '';
end;
// By Janilabo
{==============================================================================]
Explodes str with multiple separators/delimiters (d).
The importance order for d items is from left to right (=>).
So place the important ones first and then less important after those.
NOTE: Supports limit.
[==============================================================================}
function StrExplodeMultiEx(d: TStringArray; str: string; limit: Integer): TStringArray;
var
a, b, i, l, p, r, s, z, g: Integer;
m: Boolean;
begin;
SetLength(Result, 1);
l := Length(str);
s := Length(d);
if ((l > 0) and (s > 0)) then
begin
r := 0;
z := 0;
for a := 0 to (s - 1) do
begin
p := Length(d[a]);
if (p > 0) then
if (p <= l) then
begin
if (z = 0) then
z := Length(d[a])
else
if (Length(d[a]) < z) then
z := Length(d[a]);
d[r] := d[a];
Inc(r);
end;
end;
if (r > 0) then
begin
s := r;
a := 1;
p := 1;
r := 0;
while (((r + 1) < limit) and ((a + (z - 1)) <= l)) do
begin
m := False;
for i := 0 to (s - 1) do
begin
g := Length(d[i]);
if ((a + (g - 1)) <= l) then
begin
for b := 1 to g do
begin
m := (str[((a + b) - 1)] = d[i][b]);
if not m then
Break;
end;
if m then
Break;
end;
end;
if m then
begin
Result[r] := Copy(str, p, (a - p));
if ((a + (g + 1)) = l) then
Exit;
p := (a + g);
a := ((a + g) - 1);
Inc(r);
SetLength(Result, (r + 1));
end;
Inc(a);
end;
Result[r] := Copy(str, p, ((l - p) + 1));
end else
Result[0] := '';
end else
Result[0] := '';
end;
// By Janilabo
{==============================================================================]
Returns the lines of str as TStringArray.
[==============================================================================}
function StrLines(str: string): TStringArray;
var
d: TStringArray;
begin
if (str <> '') then
begin
SetLength(d, 3);
d[0] := #13#10;
d[1] := #13;
d[2] := #10;
Result := StrExplodeMulti(d, str);
end else
begin
SetLength(Result, 1);
Result[0] := str;
end;
end;
// By Janilabo
{==============================================================================]
Returns the total count of lines that str contains.
[==============================================================================}
function StrLineCount(str: string): Integer;
var
s: TStringArray;
begin
if (str <> '') then
begin
s := StrLines(str);
Result := Length(s);
end else
Result := 1;
end;
// By Janilabo
{==============================================================================]
Returns the line text from str by number.
NOTE: Line numbers start from 1!
[==============================================================================}
function StrLine(str: string; number: Integer): string;
var
d, r: TStringArray;
begin
if ((str <> '') and (number > 0)) then
begin
SetLength(d, 3);
d[0] := #13#10;
d[1] := #13;
d[2] := #10;
r := StrExplodeMultiEx(d, str, (number + 1));
if (Length(r) >= number) then
Result := r[(number - 1)]
else
Result := '';
end else
Result := '';
end;
// By Foundry
{==============================================================================]
Returns true if any of the strings (strs) are found in the given lines of the
event log.
[==============================================================================}
function isInStrings(Strs, StringsToSearch: TStringArray; LinesFromLast: Integer = -1): Boolean;
var
i, j: Integer = 0;
begin
if LinesFromLast > high(StringsToSearch) then
LinesFromLast := high(StringsToSearch);
for i := high(StringsToSearch) downto high(StringsToSearch) - LinesFromLast do
begin
for j := 0 to high(Strs) do
begin
if pos(Strs[j], StringsToSearch[i]) > 0 then
exit(true);
end;
end;
end;
// By Foundry
{==============================================================================]
Deletes the indexes. Needed to delete multiple ones!
[==============================================================================}
procedure TStringArray.deleteIndexes(indexes: TIntegerArray);
var
i, j: Integer = 0;
begin
for i to high(indexes) do
begin
self.deleteIndex(indexes[i] - j);
inc(j);
end;
end;
function getPMText(str: String): String;
var
i, j: Integer;
read: Boolean;
begin
setLength(result, 200);
for i to length(str) do
begin
if (str[i] = '>') and
(not read) then
begin
inc(i);
read := true;
end;
if read then
begin
result[j] := str[i];
inc(j);
end;
end;
setLength(result, j - 1);
end;
// By Foundry
{==============================================================================]
Type that holds important info used to find information in the various logs.
[==============================================================================}
type
TLog = record
FilteredStrings: TStringArray;
LogID, LinesToLog: Integer;
PMName: String;
end;
var
IgnoreNames: TStringArray;
CharName, WurmDirectory: String;
// Constants for LogID.
const
EVENT = 0;
PM = 1;
COMBAT = 2;
// By Foundry
{==============================================================================]
Updates the FilteredStrings field of the TLog.
[==============================================================================}
procedure TLog.update();
var
StringArray: TStringArray;
Log, i, j, k, l, LineLimit: Integer;
size: LongInt;
EndPathName, MainString: String;
IndexesToDelete: TIntegerArray;
begin
case LogID of
EVENT: //Event Log
begin
EndPathName := '_Event.2014-05';
end;
PM: //Local Log
begin
EndPathName := 'PM__' + PMName + '.2014-05';
end;
COMBAT: //Combat Log
begin
EndPathName := 'DIRECTORY HERE'; // Not yet needed.
end;
end;
if not fileExists(WurmDirectory + 'Wurm\players\' + Charname +'\logs\' + EndPathName + '.txt') then
begin
writeLn('Failed to find the player folder ' + Charname + ' in directory ' + Wurmdirectory);
writeLn(WurmDirectory + 'Wurm\players\' + Charname +'\logs\' + EndPathName + '.txt');
if LogID = PM then
exit
else
terminateScript();
end;
Log := OpenFile(WurmDirectory + 'Wurm\players\' + Charname +'\logs\' + EndPathName + '.txt', True);
size := fileSize(Log);
ReadFileString(Log, MainString, FileSize(Log));
CloseFile(Log);
if size > 900000 then // If it is over 900000 characters
begin
writeLn('Event log is ' + toStr(size) + ' characters. Quitting Wurm and deleting it.');
quit(false);
wait(2000);
if deleteFile(WurmDirectory + 'Wurm\players\' + Charname +'\logs\' + EndPathName + '.txt') then
writeLn('File successfully deleted, please restart the game.')
else
writeLn('Couldn''t delete the file. Something is wrong...');
terminateScript();
end;
StringArray := StrLines(MainString);
if length(StringArray) <= 50 then
LineLimit := length(StringArray);
if LogID = EVENT then
begin
for i := length(StringArray) - LineLimit to high(StringArray) do
begin
if i < 0 then
continue;
for j := 0 to high(IgnoreNames) do
begin
if (pos(IgnoreNames[j], StringArray[i]) > 0) then
begin
setLength(IndexesToDelete, k + 1);
IndexesToDelete[k] := i;
inc(k);
break;
end;
end;
end;
StringArray.deleteIndexes(IndexesToDelete);
end;
if LinesToLog > length(StringArray) then
LineLimit := length(StringArray)
else
LineLimit := LinesToLog;
setLength(FilteredStrings, LineLimit + 1);
for i := 0 to LineLimit - 1 do
begin
l := high(StringArray) - LineLimit + i;
if l < 0 then
l := 0;
try
FilteredStrings[i] := StringArray[l];
except
writeLn(toStr(l) + ' broke it');
break;
end;
end;
setLength(FilteredStrings, i);
MainString := '';
setLength(StringArray, 0);
end;
// By Foundry
{==============================================================================]
Evaluates the LogCheck based on its defined parameters.
[==============================================================================}
function TLog.check(StringsToFind: TStringArray; LinesFromEnd: Integer; UpdateLog: Boolean = false): Boolean;
begin
if UpdateLog then
update();
result := isInStrings(StringsToFind, FilteredStrings, LinesFromEnd - 1);
end;
function TLog.checkRecentPM(var msg: String): Boolean;
var
i: Integer;
begin
update();
for i := high(FilteredStrings) downto 0 do
begin
case between('<', '>', FilteredStrings[i]) of
PMName:
begin
msg := getPmText(FilteredStrings[i]);
exit(true);
end;
'System': exit(false);
capitalize(CharName): exit(true);
end;
end;
end;
function TLog.checkRecentPM(): Boolean; overload;
var
s: String;
begin
result := checkRecentPM(s);
end;
procedure TLog.init(_LogID, _LinesToLog: Integer; _PMName: String = '');
begin
LogID := _LogID;
if _LogID = PM then
PMName := _PMName;
LinesToLog := _LinesToLog;
end;
