SRL Archive - First Scripts

[RS3] Barbarian Village Power Fly Fisher


P1ng

2014-04-13 04:35:36

Now, technically not my first script. But it is my first script using the SRL-6 include, so any constructive criticism, testing and feedback would be greatly appreciated :)

Features -
- Action bar/manual dropping procedures
- TPA fishing spot finding
- Antiban
- Progress report


Set up -
- Fly fishing rod in toolbelt
- Feathers in inventory (Choose which slot they are in)
- If using the action bar dropping you will need to set up trout and salmon in the 1 and 2 slots before running script
- Fill out declare players


To come -
- SPS positioning and walking between spots



Progress Report -
P1ngs Power Fly Fisher
======================
Current Player: XXXXXX
Fish Caught: 1917
Fish Per/Hr: 822
Time Running: 02h 19m 59s
======================

V2.0 [current version] - Have removed walking between fishing spots. Wasn't quite buggy and making it look awfully bot-like.
- Sped up the actionbar dropping, now holds the button down instead of repeatedly pressing it.
- Next release will contain custom SPS map and walking between fishing spots when no spot is detected.

The Mayor

2014-04-13 05:43:51

Grats on you first SRL6 release! For your InvInc function, you could just use tabBackpack.waitForShift(time). And also with lape, you can return a value when you exit. So instead of this


if TabBackPack.IsFull then
begin
Result := False;
Exit;
end;

you can go


if tabBackPack.IsFull() then
exit(false);

P1ng

2014-04-13 07:08:52

Thanks for the feedback Mayor!
Feels pretty good seeing it work after all the road-blocks I ran into trying to swap my thinking over to the new include.

Wu-Tang Clan

2014-04-13 20:55:49

Wow P1ng it has been a loooong time

Godless

2014-04-14 06:24:16

Running it now. Will let you know how it goes.

EDIT: Some issues with dropping using the action bar. Won't drop trout (key 1), but will drop salmon (key 2).

EDIT 2: Swapped trout and salmon around. Seems to be working better than before.

P1ng

2014-04-14 06:39:03

That's odd… I had that issue earlier but by increasing a wait or two it stopped happening for me.
Are you perhaps a bit laggy? In which case increasing the wait @line 207 should solve the issue.

Godless

2014-04-14 06:46:31

I stopped the error by putting salmon in the first slot on the action bar instead of trout.


Here is a small report:
Current Player: **********
Fish Caught: 351
Fish Per/Hr: 850
Time Running: 24m 47s

This is on an account with less than 60 Fishing. Had to stop due to the update. Will try and get a longer one tonight and let you know if I have any other issues.

EDIT: Can't get it to run any longer than about half hour. It has trouble moving from the spots near the bridge to the spots on the small peninsula part and vice-versa.

P1ng

2014-04-19 01:18:41

Version 2.0 has now been added to the OP along with a list of the changes made.
Changed quite a bit of code and tidied everything up subtantially.

Next release will contain the custom SPS map and walking between fishing spots.