SRL Archive - Jr. Member OSR Outdated Scripts

**Outdated but I intend to update it. Eventually…**
Here is my AIO Fisher I have been working on over the past few days. I am making it available for SRL JR Members before I decide to release to the general public. (Would like some feedback as well as pinpoint any potential bugs beforehand)

If you have any questions, comments, feedback, requests, inputs, opinions, ideas, etc. Post them please. I'd like to hear from you!

What does it do?

• Loots fishing equipment from the ground if you get yours spit out
• Fishing support for any fishing spot, anywhere
• Banking support for any bank booth, almost anywhere
• BarbVillage special support: Option to Fish, Cook, and Bank(Optional) all-in-one
• On screen Xp Reports
• AntiBan
• Break handler

What type of fishing? Where at?
- Locations -
More to be added each update

• Catherby - Harpoon/Big Net, Cage/Harpoon, Small Net/Bait
• Otto's Grotto - Leaping fish - Agility and Strength requirement as well as some Barbarian Training; along with a Fishing level requirement - Heavy Rod Fishing
• Barbarian Village - Fly FIshing/Bait fishing - Cooking support here (as well as Cooking + Banking support)
• Draynor Village - Small net/Bait
• *More to be added (help me expand this list!)*

What can be fished

• Any fish - other then Karambwan fishing (will be added later)

What kind of fishing equipment is used?
Currently, the following equipment, and methods of fishing are supported
*Exp rates are subject to change as you level or change fishing options*

• Heavy fishing rod - Barbarian Fishing @ Otto's Grotto - ~40k xp/hr (Powerfishing) with added Strength and Agility xp.
• Harpoon fishing - (Barehanded fishing will be added soon) - ~20k - 30k xp/hr (Tuna/Swordfish - Banking) - ? xp/hr (Sharks (?))
• Fly fishing - ~30k xp/hr (Powerfishing)
• Lobster Pots - ~12-24k xp/hr (Banking)
• Fishing rod - Bait fishing - ~22k xp/hr (Banking)
• Small net fishing - ~3k xp/hr (Powerfishing)
• Big net fishing - ? xp/hr (?)

How do I use it?

• Instructions are inside of the script - visable at the top in Blue letters preceeded by //'s

What will I need to use this script?

• Reflection Include
• SRL - OSR Include
• Flight's AL_Functions Include - Can be found at Elfyyy's Pest Control Thread
• SMART
• (*If you do not have these or do not know how to set them up, refer to the help section please*)

Progress reports
Post yours and I will add it
[ATTACH=CONFIG]23139[/ATTACH]
[ATTACH=CONFIG]23140[/ATTACH]

Not too shabby, gratz on release!

From: Robert
Not too shabby, gratz on release!

Thank you! If you end up using it, let me know how it goes, and if you see anything I could improve upon; let me know of that as well!

From: Pakyakkistan
Thank you! If you end up using it, let me know how it goes, and if you see anything I could improve upon. (I know there are some things!)

I'll give it a test run since I have members on OSR noq

This is great buddy, congratulations on this. If I might make a suggestion, I'd like to see a list of supported locations and types of fish / fishing methods.

From: Flight
This is great buddy, congratulations on this. If I might make a suggestion, I'd like to see a list of supported locations and types of fish / fishing methods.

Thanks, Flight!
I liked the suggestion; what do you think about this?
Will be adding more fishing location IDs and equipment methods -Barb tail harpoon fishing, Barehanded Barb fishing- soon!

What type of fishing? Where at?
- Locations -
More to be added each update
Catherby - Harpoon/Big Net, Cage/Harpoon, Small Net/Bait
Otto's Grotto - Leaping fish - Agility and Strength requirement as well as some Barbarian Training; along with a Fishing level requirement - Heavy Rod Fishing
Barbarian Village - Fly FIshing/Bait fishing - Cooking support here (as well as Cooking + Banking support)
Draynor Village - Small net/Bait
*More to be added (help me expand this list!)*

What can be fished
Any fish - other then Karambwan fishing (will be added later)

What kind of fishing equipment is used?
Currently, the following equipment, and methods of fishing are supported
*Exp rates are subject to change as you level or change fishing options*
Heavy fishing rod - Barbarian Fishing @ Otto's Grotto - ~40k xp/hr (Powerfishing) with added Strength and Agility xp.
Harpoon fishing - (Barehanded fishing will be added soon) - ~20k - 30k xp/hr (Tuna/Swordfish - Banking) - ? xp/hr (Sharks (?))
Fly fishing - ~30k xp/hr (Powerfishing)
Lobster Pots - ~12-24k xp/hr (Banking)
Fishing rod - Bait fishing - ~22k xp/hr (Banking)
Small net fishing - ~3k xp/hr (Powerfishing)
Big net fishing - ? xp/hr (?)

Good to see. Will try it out later today if I can. :D
Thanks, and congrats on releasing.

Added a new update that compiles alongside the new reflection update. (Update would be V1.1) -

Just tried this out starting out fishing shrimp in Draynor. It finds the fishing spot fine, but after I catch some it constantly left clicks on a shrimp in my inventory (every 5 seconds approximately). This is an issue because it is constantly selecting and unselecting the shrimp in my inventory. Besides being botlike, if one is selected when trying to select a new fishing spot after it moves, it's unable to find the fishing spot. Here are my current settings:

const
    FishingID = 3218;//2261 Otto's Grotto - 3219 Barbarian Village Fishing spots (Lure and Bait) - 3218 Draynor Fishing spots (Big net and Bait) - 3223 Lumbridge Tutor location spots (Small net) - 3213 Catherby (Big net and Harpoon) - 3212 Catherby (Cage and Harpoon) - 3211 Catherby (Small net and Bait)
    FishingChoice = 'Net';//Name of the option your fishing IE: 'Bait', 'Net', 'Harpoon', 'Cage'
    //FishingChoice is CASE SENSITIVE
    Net = True;//Are we using a Big or Small net?
    Cage = False;//Are we using a Lobster pot?
    Harpoon = False;//Are we using a Harpoon?
    Drop = True;//Do we want to drop our inventory, or bank it? (Drop = True-Droping inventory, Drop = False-Banking inventory)
    BarbVillage = False;//Do you want to cook what you fished from the river near Barbarian Village?//[To-do] Add door support, add cooking of River baited fish
    CustomBank = False;//If bank booth is farther then 104 tiles away when starting script
    CBX = 2810;//X Tile position for Custom Banking (Refer to custom banking)
    CBY = 3443;//Y Tile position for Custom Banking (Refer to custom banking)
    //CBX's - Catherby CBX = 2810 - Edgeville CBX = 3095 -
    //CBY's - Catherby CBY = 3443 - Edgeville CBX = 3491 -
    RunDirection = 'E';
    TakeBreaks = False;//Do you wish to take breaks?
    BreakIn = 120;
    BreakFor = 65;
    RandBreakIn = 60;
    RandBreakFor = 30; 

I waited to get a full inventory and it dropped them no problem, so this seems like a very solid script!
Edit - I'll try other fish when I get my level up and see if I have the same issue.
Edit 2 - Tried fly fishing in barb village. Worked okay for the most part (no clicking on stuff in inventory issue), but just a few things I noticed: 1) when running to edgeville bank, it would click on the wrong side of the river and cause the player to run in the opposite direction from the bank. It would then try running back towards the bank and click the other side of the river again causing it to run back and forth. 2) Has a little bit of difficulty finding the bank.
Overall as long as I babysit the banking part, the script runs well!

From: RyGuy
Just tried this out starting out fishing shrimp in Draynor. It finds the fishing spot fine, but after I catch some it constantly left clicks on a shrimp in my inventory (every 5 seconds approximately). This is an issue because it is constantly selecting and unselecting the shrimp in my inventory. Besides being botlike, if one is selected when trying to select a new fishing spot after it moves, it's unable to find the fishing spot. Here are my current settings:

This is more then likely DTM for SolveBox, thinks you have a Mystery box in your inventory because the DTM will match for it(having the same problems in other scripts [Onion seeds do the same thing] More then likely will just post an updated DTM of the mystery box)

const
    FishingID = 3218;//2261 Otto's Grotto - 3219 Barbarian Village Fishing spots (Lure and Bait) - 3218 Draynor Fishing spots (Big net and Bait) - 3223 Lumbridge Tutor location spots (Small net) - 3213 Catherby (Big net and Harpoon) - 3212 Catherby (Cage and Harpoon) - 3211 Catherby (Small net and Bait)
    FishingChoice = 'Net';//Name of the option your fishing IE: 'Bait', 'Net', 'Harpoon', 'Cage'
    //FishingChoice is CASE SENSITIVE
    Net = True;//Are we using a Big or Small net?
    Cage = False;//Are we using a Lobster pot?
    Harpoon = False;//Are we using a Harpoon?
    Drop = True;//Do we want to drop our inventory, or bank it? (Drop = True-Droping inventory, Drop = False-Banking inventory)
    BarbVillage = False;//Do you want to cook what you fished from the river near Barbarian Village?//[To-do] Add door support, add cooking of River baited fish
    CustomBank = False;//If bank booth is farther then 104 tiles away when starting script
    CBX = 2810;//X Tile position for Custom Banking (Refer to custom banking)
    CBY = 3443;//Y Tile position for Custom Banking (Refer to custom banking)
    //CBX's - Catherby CBX = 2810 - Edgeville CBX = 3095 -
    //CBY's - Catherby CBY = 3443 - Edgeville CBX = 3491 -
    RunDirection = 'E';
    TakeBreaks = False;//Do you wish to take breaks?
    BreakIn = 120;
    BreakFor = 65;
    RandBreakIn = 60;
    RandBreakFor = 30; 

I waited to get a full inventory and it dropped them no problem, so this seems like a very solid script!

Thank you! Still needs some work tho, have been working on it and adding things in my spare time; will be adding some fixes soon in the next update(just need more time to ensure that what I have added actually works)

Edit - I'll try other fish when I get my level up and see if I have the same issue.
Edit 2 - Tried fly fishing in barb village. Worked okay for the most part (no clicking on stuff in inventory issue), but just a few things I noticed: 1) when running to edgeville bank, it would click on the wrong side of the river and cause the player to run in the opposite direction from the bank. It would then try running back towards the bank and click the other side of the river again causing it to run back and forth.

This can be fixed by changing BarbFishing to True; For some reason I completely forgot to add that in the commented section of that - Its not JUST for cooking fish, if you have Drop = False and Barbfishing = true it will use a specific set path which avoids the river crossing crap - (had it happen to me in testing, was very annoying lmfao)

2) Has a little bit of difficulty finding the bank.

Are you using custom banking? If not, make sure you are within 54 tiles away of the bank booth when starting the script. You can start the script up, wait for it to 'get going' and then pause it or disable smart and then go near your fishing location and it should get the bank booth. If you are making sure you are within 54 tiles away and are not using custom banking (or if you are not using custom banking and not having problems or only having problems when you custom bank) then let me know and I will look into a fix for that)

Overall as long as I babysit the banking part, the script runs well!

Thanks for the feedback; need to know these things to know what needs to be improved on and fixed! Soon, there will be no reason for you to Babysit once I fix the problems

Answered you in Bolded and underlined text in the above quoted text. Thanks again for the feedback!

In utter news

Figured I might as well post the update I currently have! Enjoy and let me know. Whirlpool detection should work now, and added a special feature from Frement that will detect if you have fishing equipment in your inventory (no standing around if something happens and we loose our fishing equipment), on top of that also changed it from ALWAYS right clicking, if the option is left-click instead, it will do that!
Let me know how this new update is!

This may be a very stupid question, but in the new version (2.1) the options are there saying the fishing ID's, but there is no spot to enter it. I tried adding the constant FishingID that you had in the last version, but it didn't work.
Thanks :)

V2.1 was a flop, download V2.2 to fix the not fishing error - now also supports ALL Fishing spots at the Fishing Guild! - Just have to grab your own IDs for the fishing spots - (or give me some time to add them in! Lol - Also, give me any suggestions of IDs I should grab while i'm at it! (ANY Fishing locations I don't already have and you'd like) -

Forgot to mention it in the script - Just mentioned it as an Edit in my previous comment. Sorry about that. Added it in there - You will now need to enter the fishing ids in the DeclarePlayers procedure in 'Integers'. This will also allow you to add Multiplayer and give different players different fishing spots :D (not going to add multiplayer, if you want it; feel free to check the tuts on adding it)
@RyGuy; Here is your fix. Sorry about that

From: Pakyakkistan
V2.1 was a flop, download V2.2 to fix the not fishing error - now also supports ALL Fishing spots at the Fishing Guild! - Just have to grab your own IDs for the fishing spots - (or give me some time to add them in! Lol - Also, give me any suggestions of IDs I should grab while i'm at it! (ANY Fishing locations I don't already have and you'd like) -

Forgot to mention it in the script - Just mentioned it as an Edit in my previous comment. Sorry about that. Added it in there - You will now need to enter the fishing ids in the DeclarePlayers procedure in 'Integers'. This will also allow you to add Multiplayer and give different players different fishing spots :D (not going to add multiplayer, if you want it; feel free to check the tuts on adding it)
@RyGuy; Here is your fix. Sorry about that

Working much better now, thanks! One thing.. not sure if it's the script or the plugin or what.. but I got a sandwhich lady while cooking and it failed to recognize her. I noticed her before she did the dirty and saved it but just thought I'd mention it. Also, gets to the bank fine but sometimes takes around a minute to actually find the booth. I'll keep it going a bit and let you know if anything else comes up :) Thanks a lot for the quick help and updates!

Edit: If you gain a cooking level while cooking, it failed to cook the remainder of the fish. Not really an issue as it banked them just fine, but something I thought you might want to be aware of.

From: RyGuy
Working much better now, thanks! One thing.. not sure if it's the script or the plugin or what.. but I got a sandwhich lady while cooking and it failed to recognize her. I noticed her before she did the dirty and saved it but just thought I'd mention it. Also, gets to the bank fine but sometimes takes around a minute to actually find the booth. I'll keep it going a bit and let you know if anything else comes up :) Thanks a lot for the quick help and updates!

Edit: If you gain a cooking level while cooking, it failed to cook the remainder of the fish. Not really an issue as it banked them just fine, but some I thought you might want to be aware of.

The Random events would be Reflection Include, amd Sandwhich lady isn't currently supported.
I'll be releasing my AIO Woodcutter on a few days, and posting a bankong fix that I implemented in that script (clicks to bank while walking inside of the bank - much more efficient-)

Let me know anything else!

i keep getting this error

Exception in Script: Unable to find file 'SRL-OSR/SRL/misc/al_functions.simba'

Current update has been released - Others have been removed
Just so everyone is clear on which to use; I have removed the older versions and have added V2.3 which is the most up to date version of this.
V2.3 has the added quicker bank fixes as well as removal of the SolveBox random solver (the one that was separate from the reflection random solver) so you will no longer have your inventory spam clicked if you have a lobster cage or similar item in your inventory.

Let me know how it goes and as always; Leave my feedback, any progress reports, and anything else! Feel free to PM me about problems as well, we'll figure them out!

not compiling

From: wister1
not compiling[/QUOTE]

Should compile now with V2.31 - Sorry about that…
Current update of the script will compile properly

E: Inb4 I forgot something else

From: Pakyakkistan

From: wister1
not compiling[/QUOTE]

Should compile now with V2.31 - Sorry about that…
Current update of the script will compile properly

E: Inb4 I forgot something else

confirming that at least its working now, will keep you posted if everything is working

keep the good man and thx for quick reply

Currently running V2.31. I don't know if you changed the banking procedure for catherby at all or just draynor, but I just watched it rotate the camera and right click for about two minutes until it found the bank there. Also, after banking the camera was turned so it was looking at the player from behind. It was a low camera angle and there was a tree blocking the player. It just kept right clicking on the fishing spot and selecting cage fish even though the character was already fishing.

confirming, its having alot of troubles banking at catherby

Looks good, can't say i'll be trying it.

I've maxed out fishing at level 53 for heroes :D

From: wister1
confirming, its having alot of troubles banking at catherby

From: RyGuy
Currently running V2.31. I don't know if you changed the banking procedure for catherby at all or just draynor, but I just watched it rotate the camera and right click for about two minutes until it found the bank there. Also, after banking the camera was turned so it was looking at the player from behind. It was a low camera angle and there was a tree blocking the player. It just kept right clicking on the fishing spot and selecting cage fish even though the character was already fishing.

Fixed. Current version v2.32.

Looks like you hit the nail on the head with the banking in 2.32 ^.^ Overall the script is going very strong

One small thing with the banking that really isn't a big deal is that after the bank screen shows up, it right clicks on something in the inventory before depositing the fish.

A problem that is a little more of an issue is… if someone else's lobster pot is picked up off of the ground, when it goes to the bank, it deposits all of them, not just the extras. The script gives the error "We have no idea what just happened" and logs out.

Thanks a lot for the quick replies and updates to this script! We really do appreciate it!

From: RyGuy
Looks like you hit the nail on the head with the banking in 2.32 ^.^ Overall the script is going very strong

One small thing with the banking that really isn't a big deal is that after the bank screen shows up, it right clicks on something in the inventory before depositing the fish.

A problem that is a little more of an issue is… if someone else's lobster pot is picked up off of the ground, when it goes to the bank, it deposits all of them, not just the extras. The script gives the error "We have no idea what just happened" and logs out.

Thanks!

I will look into using my GetInventory stuff to JUST check for ground items when we don't have any fishing equipment; then tell us that 'What!?' and logout. Should prevent that.

Still working on the banking stuff; eventually i'll get it to work how i'd like it to!

im having troubles now dunno why, i start the script and it doesnt do nothin, im close to the fish spots is that my problem or is there a specific place to begin, im fishing at catherby

From: wister1
im having troubles now dunno why, i start the script and it doesnt do nothin, im close to the fish spots is that my problem or is there a specific place to begin, im fishing at catherby

Update on Thursday has changed the Fishing spot IDs. Quite busy atm; when I get around to it I will update the IDs and then update the script with the new IDs.

If anyone knows how to get IDs and wouldn't mind posting any they have got since the update, please post them here for others. Going to be awhile for me to get around to it, and I really don't feel like explaining how to get the IDs yet(going to take me awhile to get around to it).

Thanks

Any update on getting the fishing spot ID's changed for this?

From: Pakyakkistan
Update on Thursday has changed the Fishing spot IDs. Quite busy atm; when I get around to it I will update the IDs and then update the script with the new IDs.

If anyone knows how to get IDs and wouldn't mind posting any they have got since the update, please post them here for others. Going to be awhile for me to get around to it, and I really don't feel like explaining how to get the IDs yet(going to take me awhile to get around to it).

Thanks

If you could explain how ID's are gotten, I would glady work on getting new ones for the update. But right now, interest is low and resources are scarce. =(

I'm getting back into OSRS and simba… Nice to see theres reflection now! I'm sure coordination of the world and walking will be easier now! Nice script!

From: Pakyakkistan
Added a new update that compiles alongside the new reflection update. (Update would be V1.1) -

Hey! Looks like you've created a great script!
I get this error while trying to run it:

[Hint] C:\Simba\Includes\SRL-OSR\SRL\Reflection\AntiRandoms\R_TalkRandoms.simba(23:3): Variable 'F' never used at line 22
[Error] C:\Users\Home\Desktop\Scripts\Fishing\[Reflection] [OSR] [AIO] PakYak's Fisher V2.32.simba(140:10): Duplicate identifier 'R_GETWIDGET' at line 140

Now I know it's something I didn't download but I was wondering if you could tell me what it is that I need to download. I'm heading off to a party and I saw your post of this script so I was wondering if you could tell me since I don't have much time to look around right now. Thanks man and once again, nice release!

EDIT: I went through and made sure I downloaded everything, I had everything already downloaded so I deleted them all and redownloaded everything just to be sure. But I still got that error. Any idea what's going on? I'm using the newest version 2.32

From: Success
Hey! Looks like you've created a great script!
I get this error while trying to run it:

[Hint] C:\Simba\Includes\SRL-OSR\SRL\Reflection\AntiRandoms\R_TalkRandoms.simba(23:3): Variable 'F' never used at line 22
[Error] C:\Users\Home\Desktop\Scripts\Fishing\[Reflection] [OSR] [AIO] PakYak's Fisher V2.32.simba(140:10): Duplicate identifier 'R_GETWIDGET' at line 140

Now I know it's something I didn't download but I was wondering if you could tell me what it is that I need to download. I'm heading off to a party and I saw your post of this script so I was wondering if you could tell me since I don't have much time to look around right now. Thanks man and once again, nice release!

EDIT: I went through and made sure I downloaded everything, I had everything already downloaded so I deleted them all and redownloaded everything just to be sure. But I still got that error. Any idea what's going on? I'm using the newest version 2.32

I have been away for awhile. You are most likely getting the last error due to it being out of date. I plan to return in due time and redo most of my scripts and release new ones as time goes on. Hopefully I get back to having the time to do both of those things.