SRL Archive - SRL Development and Help

Black Outline For Items


Yago

2014-03-14 12:55:40

As it is known, the black outline for RS3 items is denoted in the library by:

ITEM_OUTLINE_BLACK = 131072;

However, these is a secondary color for the outline. The secondary color is 65536.

I am just wondering why the include doesn't check for this color as well. This color is not just present for item outlines but also as the outline for ITEM_TEXT_YELLOW.

I think its important to check for this color because of cases where the first color is not present, such as the following picture:

[ATTACH=CONFIG]23084[/ATTACH]

This is my quickslot. The quickslot seems to remove the black outline that is checked for by functions such as items.isItemIn(box), which I feel should include the second color check.

Of course, there may be a reason why this is not implemented.

Thoughts?

Turpinator

2014-03-14 13:09:57

@Ashaman88; – look into this!

Olly

2014-03-14 14:24:36

result := findColorTolerance(x, y, 131072, area, 1, colorSetting(0)); should work.

Clarity

2014-03-14 15:16:05

Lol oops, I've always searched for 65536, always thought the other one wasn't the outline.

Brotein

2014-03-14 15:46:45

One of these colors isn't present in production screen, I forget which one, I think it's 131072. Easy to fix the DTMs but worth noting that the item outline in your bank/inv will not be the same as the production screen.

Yago

2014-03-15 00:45:42

From: Olly
result := findColorTolerance(x, y, 131072, area, 1, colorSetting(0)); should work.


Is it worth it to change SRL then? In my pic above SRL fails to work. The question is whether it should…

Olly

2014-03-15 01:06:22

From: Yago
Is it worth it to change SRL then? In my pic above SRL fails to work. The question is whether it should…


Yes it is, I'm just doing some other things atm :p

Yago

2014-03-15 01:36:19

From: Olly
Yes it is, I'm just doing some other things atm :p


In that case I'll see if I can handle a few things

E: Pull request sent.

Coh3n

2014-03-15 14:22:17

This fix is in the latest version of SRL. :)