SRL Archive - SRL-OSR Snippets

Bank.simba; updated [12-9-2013]

Flight

2013-09-12 12:39:45

Heya,

So a few hours ago OSRS was updated with some extra features added to bank accounts in-game and it might have broken some of your scripts. So I took a bit of time and updated a couple things to handle all the changes they made. A handful of functions updated and some new procedures added. Here's what was updated in-game:


And here's what I fixed/added:
  • BankScreen function fixed
  • WithdrawEx updated to use pre-defined X amounts
  • Notes procedure updated
  • SearchBank procedure added
  • Added QuickDeposit pocedure
  • Added getBankItemCount function
  • Handling of 'Withdraw-All-but-one'

-Install instructions-
Simply replace your current "bank.simba" with the one I attached to this post. You'll find it in "Includes > SRL-OSR > SRL > core > bank.simba".

Edit:
Oh yes, whoever maintains the SRL-OSR include via Github, verify this and add it to the include ASAP.

Hoodz

2013-09-12 13:17:58

thanks flight!

btw: hooks are not changed this update

Solar

2013-09-12 15:05:50

Great work and super fast. Cheers Flight.
Good news about the hooks too. :)

repahu

2013-09-12 15:38:08

Thanks!
I fixed some global constants too, cause i use BankIndexToMSBox() func.
Global constants that have to be changed are MBX1,MBX2,MBY1,MBY1,MBCX,MBCY.
these are my vals:

MBX1 = 73;
MBY1 = 71;
MBX2 = 446;
MBY2 = 280;

googlebear

2013-09-12 19:16:47

Thank you! Much appreciated, very very nice of you :)

Flight

2013-09-12 21:01:02

From: repahu
Thanks!
I fixed some global constants too, cause i use BankIndexToMSBox() func.
Global constants that have to be changed are MBX1,MBX2,MBY1,MBY1,MBCX,MBCY.
these are my vals:


Thank you, I didn't know notice they needed to be change. If you've verified that they're correct then I'll update the OP with your changes.

repahu

2013-09-13 05:16:09

From: Flight
Thank you, I didn't know notice they needed to be change. If you've verified that they're correct then I'll update the OP with your changes.


They work fine for me. There can be 1px diff, cause my mouse moves 2px steps even if i set the mouse DPI to minimal.
You might have noticed, that 1 row has been removed and the gap between the slots have been changed on the Y axis. So in bank.simba(your version) line 521 needs some correction.
Result := Point(MBX1 + ((Index mod 8) * 48), MBY1 + (44 * (Index div 8)));

samerdl

2013-09-13 09:02:20

Needs to be committed to the official include as well.

Nice work flight.

Olly

2013-09-13 21:04:03

@Flight

Thought id give 07 some love…. https://github.com/SRL/SRL-OSR/commit/320e401587894bd9e632b64cd2c146d5cb9d36b8

Only added your bank.simba, but if anything else needs adding feel free to pm/posthere just make sure works :)

Flight

2013-09-13 21:19:08

From: Olly
@Flight

Thought id give 07 some love…. https://github.com/SRL/SRL-OSR/commit/320e401587894bd9e632b64cd2c146d5cb9d36b8

Only added your bank.simba, but if anything else needs adding feel free to pm/posthere just make sure works :)


Awesome, thank you. I'll drop you a line if I come across anything else for sure.

Flight

2013-10-17 10:51:55

The recent update broke the current Bank.simba so I've updated it to work with the current RS. It should now once again correctly handle withdrawing items. Also "Withdraw-All-but-one" was included in this patch, to use this option simply set "-1" as the amount to be withdrawn.

Olly

2013-10-17 10:55:56

https://github.com/SRL/SRL-OSR/commit/35bfb99d942e2838344ecc29580b74ceb0ff7f25 :)

Flight

2013-10-17 10:58:51

Very good, thank you once again Mr Olly.

Syntax

2013-10-26 07:38:38

Good job Flight, thanks for this :)