denart5
2013-07-20 15:38:06
whatever delete pls
SRL Archive - Archive
denart5 - SRL Member Application
NKN
2013-07-20 16:01:40
I'm going to vote no for the following reasons.
1) You seem to use an ACA generated function. Correct me if I'm wrong
2) In your Repair function, you do MMouse, check for Uptext, then Mouse again You can just do ClickMouse2
3) Your standards are off
4) You use FindObj a ton
5) You use waits, and then immediately move on to the next part without failsafes. How do we know if it completed successfully?
6) Here's my biggest one. You do not have multiplayer enabled in your script.
Sorry mate.
1) You seem to use an ACA generated function. Correct me if I'm wrong
2) In your Repair function, you do MMouse, check for Uptext, then Mouse again You can just do ClickMouse2
3) Your standards are off
4) You use FindObj a ton
5) You use waits, and then immediately move on to the next part without failsafes. How do we know if it completed successfully?
6) Here's my biggest one. You do not have multiplayer enabled in your script.
Sorry mate.
rj
2013-07-20 16:22:49
Don't give up just yet, the application has only been open for a few minutes. You should keep it open to see peoples feedback :s
denart5
2013-07-20 16:26:23
From: NKN
1) You seem to use an ACA generated function. Correct me if I'm wrong
Yes, how else.
From: NKN
4) You use FindObj a ton
It does the job for me.
From: NKN
5) You use waits, and then immediately move on to the next part without failsafes. How do we know if it completed successfully?
I tested the times that it would take max so no reason to know if it worked and if it didn't it will logout later.
From: NKN
6) Here's my biggest one. You do not have multiplayer enabled in your script.
Why do I need to have multiplayer enabled? One account is enough for my own use.
Rich
2013-07-20 17:00:38
I love your attitude.
Sjoe
2013-07-20 17:01:31
http://villavu.com/forum/showthread.php?t=74195
Here's a list of things u should know.
Findobj might work do the trick for u, but it's mandatory to know TPA/ATPA usage.
Also not everybody gets in on their first attempt, accept the critism that people share with u. Learn from it and work on it!
Don't let that RJJ attitude affect u!
Here's a list of things u should know.
Findobj might work do the trick for u, but it's mandatory to know TPA/ATPA usage.
Also not everybody gets in on their first attempt, accept the critism that people share with u. Learn from it and work on it!
Don't let that RJJ attitude affect u!
rj
2013-07-20 17:02:03
Yes, how else.
http://villavu.com/forum/showthread.php?t=49067
It does the job for me.
In the long run for other things it won't
I tested the times that it would take max so no reason to know if it worked and if it didn't it will logout later.
But what if it doesn't? Should have more of a fail-safe then logging out (logging out shouldn't be the first failsafe IMO in a lot of situations), the how would the script run for long periods of time?
Why do I need to have multiplayer enabled? One account is enough for my own use.
It looks good
masterBB
2013-07-20 17:08:17
If you don't have anything nice to say then don't say anything at all.
Please move yourself into a person who just started scripting. No complaints about attitude or negative talking from this point onwards.
Also @denart5, use this as a learning moment. It is not an offense.
e:
Script was gone a bit fast. But here is my review:
I can see you put much effort into the script. You have shown some solid basic understanding of scripting. techniques. Good script overall. But there were some points that needed some polishments.
You seem to have repeated some code a bit. Try to make it into a function. IIRC there was this lists of waits and mousebox calls, can you think of a way to shorten that. For example by using one function taking an array of coords.
Another thing was that at some points you lacked some failsafes. A good indication of when to use a failsafe is that you never should click before checking the situation at least once, preferably twice. This will greatly improve your scripts running potential.
It is overall not enough for SRL members imo. Good luck, you are heading in the right direction.
Please move yourself into a person who just started scripting. No complaints about attitude or negative talking from this point onwards.
Also @denart5, use this as a learning moment. It is not an offense.
e:
Script was gone a bit fast. But here is my review:
I can see you put much effort into the script. You have shown some solid basic understanding of scripting. techniques. Good script overall. But there were some points that needed some polishments.
You seem to have repeated some code a bit. Try to make it into a function. IIRC there was this lists of waits and mousebox calls, can you think of a way to shorten that. For example by using one function taking an array of coords.
Another thing was that at some points you lacked some failsafes. A good indication of when to use a failsafe is that you never should click before checking the situation at least once, preferably twice. This will greatly improve your scripts running potential.
It is overall not enough for SRL members imo. Good luck, you are heading in the right direction.
denart5
2013-07-20 17:11:30
From: Officer Barbrady
Don't give up just yet, the application has only been open for a few minutes. You should keep it open to see peoples feedback :s
The definite "No"'s I smell from having 3 no's in 5 minutes is enough to remove the lower than mediocre script and text. I thought I was way closer to "yes" than this. Feedback wouldn't matter as I'm not planning to script anymore in the near future or after.
Sjoe
2013-07-20 17:14:38
From: denart5
The definite "No"'s I smell from having 3 no's in 5 minutes is enough to remove the lower than mediocre script and text. I thought I was way closer to "yes" than this. Feedback wouldn't matter as I'm not planning to script anymore in the near future or after.
Gij laat de moed veel te rap vallen. Sommige doen er 3/4 over voordat ze geaccepteerd worden.
Werkt gewoon aan uw fouten en aanvaard kritiek! Valt te zien aan uw gedrag dat je snel opgeeft.
Slechte eigenschap om te hebben in't leven.
Ben er zeker van dat je volgend keer wel door geraakt :)
rj
2013-07-20 17:16:54
From: denart5
The definite "No"'s I smell from having 3 no's in 5 minutes is enough to remove the lower than mediocre script and text. I thought I was way closer to "yes" than this. Feedback wouldn't matter as I'm not planning to script anymore in the near future or after.
Then what was the point in applying -.-
I have done the same thing your doing right now trust me it won't work out mang
NKN
2013-07-20 17:28:54
From: Sjoe
Gij laat de moed veel te rap vallen. Sommige doen er 3/4 over voordat ze geaccepteerd worden.
Werkt gewoon op uw fouten en aanvaard kritiek! Valt te zien aan uw gedrag dat je snel opgeeft.
Slechte eigenschap om te hebben in't leven.
Ben er zeker van dat je volgend keer wel door geraakt :)
Keeping your script up gives you better criticism to improve.
It only hurts you to not keep it up.
Sjoe
2013-07-20 17:31:05
From: NKN
Keeping your script up gives you better criticism to improve.
It only hurts you to not keep it up.
Oh u speak googlestranslate!
Yeah he's acting like RJJ atm.
masterBB
2013-07-20 17:35:57
Guys, stay a bit mature please. From this point please stop it.
Chris!
2013-07-20 18:06:38
Denart5, I think the removal of your post contents has shown that you have a bad attitude toward failing, in this case SRL members. The vote now is 0 yes, 3 no. If you did actually deserve it, then you could easily drag that back but from the above comments it is unlikely.
If you apply again, please don't be like this. Show that you are happy to edit your script for the better and it will go a long way. Attitude means alot in these applications.
-Chris!
If you apply again, please don't be like this. Show that you are happy to edit your script for the better and it will go a long way. Attitude means alot in these applications.
-Chris!
[XoL]
2013-07-20 20:59:07
I know everyone has already stated everything that basically had to be said, so I won't repeat it.
The only thing I can leave for you is this is a learning community, and although some comments may come off as harsh they are only there to help a person improve in their abilities.
If it is true that you do not plan on continuing scripting, well I am sorry to hear that and I wish you the best in whatever path you decided to take :)
The only thing I can leave for you is this is a learning community, and although some comments may come off as harsh they are only there to help a person improve in their abilities.
If it is true that you do not plan on continuing scripting, well I am sorry to hear that and I wish you the best in whatever path you decided to take :)
The Mayor
2013-07-20 21:15:15
@denart5 put your script back up there mate, I would love to give you some feedback :) I'll tell you a little secret, half of the SRL members on this thread failed their first app :)
Justin
2013-07-21 01:49:37
I am disappointed in the way some SRL members have handled/replied to this application.
@denart5; Since you have withdrawn your application, I am going to close this one.
Feel free to re-apply in 7 days mate. Best of luck in the future.
Cheers
Justin.
@denart5; Since you have withdrawn your application, I am going to close this one.
Feel free to re-apply in 7 days mate. Best of luck in the future.
Cheers
Justin.