SRL Archive - OSR Outdated / Broken Scripts

PsychoticPk's first 2007 Runescape Script: Iron Power miner
PLEASE POST ALL BUGS FOUND ON THIS FORUM AND GIVE FEEDBACK OF THIS SCRIPT, THANKS

INSTRUCTIONS
-Weild Pickaxe
-Be near Iron ores, any should work as it is color based.

REQ'S
-15+ Mining

Version 1.0 ('Beta')
-Please Inform me of any bugs you may find.

powerminer or does it bank ?

From: capmasta
powerminer or does it bank ?

Can You Read ?

From: capmasta
powerminer or does it bank ?

Currently it does not bank, if i get more people to test it out and learn to make scripts walk, I'll add banking

Hey PsychoticPk. Grats on the release, I assume it's your first? If so, nice job.

Just a couple of suggestion on how to improve your script.

One thing I noticed is that when dropping your ore, there's no check to make sure it is actually ore that is being dropped. You could use DTMs to make sure nothing is getting dropped that shouldn't be. You could also use DTMs to accurately count the amount of ore mined, instead of just always adding 28. Check out this guide: http://villavu.com/forum/showthread.php?t=47845

Another thing I noticed is this:

        Case Random(2) of
          0: Mouse(x, y, 0, 0, True);
          1: Begin
              Mouse(x, y, 0, 0, True);
             end;
        end;       

This confused me as you'll always do the same, so you may as well just have

ClickMouse2(mouse_Left)

As that will also get the mouses current position.

My final suggestion will help you detect when you've finished mining. Currently you're relying on the uptext changing, but you could use PixelShift instead, as this will allow you to move your mouse from the rock, and perform anti-ban if you want, making your script much like a human. It's actually very simple, but effective. Here's a guide for that: http://villavu.com/forum/showthread.php?t=74090

Once again, grats on the release :)

From: Rich
Hey PsychoticPk. Grats on the release, I assume it's your first? If so, nice job.

Just a couple of suggestion on how to improve your script.

One thing I noticed is that when dropping your ore, there's no check to make sure it is actually ore that is being dropped. You could use DTMs to make sure nothing is getting dropped that shouldn't be. You could also use DTMs to accurately count the amount of ore mined, instead of just always adding 28. Check out this guide: http://villavu.com/forum/showthread.php?t=47845

Another thing I noticed is this:

        Case Random(2) of
          0: Mouse(x, y, 0, 0, True);
          1: Begin
              Mouse(x, y, 0, 0, True);
             end;
        end;       

This confused me as you'll always do the same, so you may as well just have

ClickMouse2(mouse_Left)

As that will also get the mouses current position.

My final suggestion will help you detect when you've finished mining. Currently you're relying on the uptext changing, but you could use PixelShift instead, as this will allow you to move your mouse from the rock, and perform anti-ban if you want, making your script much like a human. It's actually very simple, but effective. Here's a guide for that: http://villavu.com/forum/showthread.php?t=74090

Once again, grats on the release :)

Thanks for the tips :) The pixel shift one is being a pain to get working lol. Also, I know this isn't really the correct spot to ask this - If I use dtm's to drop the ores is there any specific way to go about doing in, or would it just end up being

 Drop(IronDTM); 

once again, thanks for the advice :)

It's a bit more long winded than just that. You'll have to search the inventory for the DTM, then move and click the mouse and chose the option to drop the ore.

https://github.com/SRL/SRL-OSR/blob/master/SRL/core/inventory.simba#L908

From: Ollybest
https://github.com/SRL/SRL-OSR/blob/master/SRL/core/inventory.simba#L908

People should really tell Olly how awesome he is more often. He knows everything in SRL :p

From: Ollybest
https://github.com/SRL/SRL-OSR/blob/master/SRL/core/inventory.simba#L908

Kind of new to this, so It'll take me a bit to understand the link lol, but Thanks for the help. Hopefully this weekend or something I can work on learning the DTM's and dropping the ores, as well as pixel shifting

testing this now will respond back with feedback soon :)

not sure if these are bugs but if you start in the mine inbetween port khazard and yanile it does not detect the iron ore and it trys to chop trees, and does other random things

Unknown identifier 'FindNPCChatText' at line 37

Why don't any scripts work :(

it says- Exception in Script: Unable to find file 'srl-osr/srl.simba' used from 'C:\Simba\Scripts\iron miner.simba' how do i fix this?

From: SeeJay9696
it says- Exception in Script: Unable to find file 'srl-osr/srl.simba' used from 'C:\Simba\Scripts\iron miner.simba' how do i fix this?

http://villavu.com/forum/showthread.php?t=47714

Im new to this, but the client loads and everything and it mines for me but the only way itll mine is if I change the screen to set on a rock. I have to manually adjust screen everytime I want it to mine one ore.

From: hkbell
Im new to this, but the client loads and everything and it mines for me but the only way itll mine is if I change the screen to set on a rock. I have to manually adjust screen everytime I want it to mine one ore.

More then likely because the script is outdated. I'm sure if you look at the script you can work towards learning some of the procedures out and messing with the functions to get it to work for you. Or, wait until the OP updates the script.