SRL Archive - OSR Help

hey guys this is my noob script have a look , it doesn't detect random events idk why, and i was wondering how can i shorten the code for my drop function?

program new;
{$i srl-osr/srl.simba}

Procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  Players[0].Name :='';
  Players[0].Pass :='';
  Players[0].Nick :='aid';
  players[0].Active:=True;
end;

Procedure AntiBan;
  begin
    case Random(4) of
      0:
      begin
        HoverSkill('WoodCutting', False);
        Wait(1000 + Random(1000));
      end;
      1:  PickUpMouse;
      2:
      begin
        MakeCompass(Random(360));
        Wait(500 + Random(500));
        MakeCompass(Random(360));
      end;
      3:  CompassMovement(10, 30, True);
      4:  BoredHuman;
    end;
  end;

Procedure EmptyInventory;

  begin
  if InvFull then
    MouseItem(1, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(2, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(3, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(4, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(5, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(6, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(7, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(8, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(9, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(10, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(11, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(12, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(13, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(14, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(15, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(16, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    FindNormalRandoms;
    MouseItem(17, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(18, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(19, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(20, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(21, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(22, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(23, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(24, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(25, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(26, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(27, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    MouseItem(28, mouse_right);
    ChooseOption('Drop')
    Wait(100 + Random(300))
    AntiBan;
end;

Procedure ChopTree;
var x, y: integer;
begin
  repeat
    if FindObj(x, y, 'Chop down Oak', 3561844, 25) then
    ClickMouse(x, y, 2);
    FindNormalRandoms;
    AntiBan;
    repeat
      Wait(1500 + Random(250))
      FindNormalRandoms;
      EmptyInventory;
      until not IsUpText('Chop down Oak')

  until InvFull;
end;


begin
  ClearDebug;
  SetUpSRL;
  ActivateClient;
  DeclarePlayers;
  LoginPlayer;
  repeat
  ChopTree;
  EmptyInventory;
  AntiBan;
  until (false)
end.

You have 2 options to improve dropping everything, you could use a for loop instead, along the lines of:

if InvFull then
  for i:=1 to 28 do
  begin
    mouseItem(i, mouse_right);
    ChooseOption('Drop');
  end;

Also from the looks of it, it seems like you're always dropping every position even if inv not full because you don't have a begin…end around the code you want to only happen if invfull.

Anwyay, you could also use DTMs to select each log and even allow for other items (such as an axe) in your inventory and only drop the logs. Following the first 3 portions of this tutorial should help you learn DTMs http://villavu.com/forum/showthread.php?t=77691.

And as for detecting random events, which events is it not detecting?

Some randoms aren't done yet, so this may be the reason why it isn't detected. If you check out the topic below it will tell you what randoms are currently working, which are not working but are detected, and which aren't detected and not working.

link:


http://villavu.com/forum/showthread.php?t=98207