SRL Archive - Archive

How Long have You Played Runescape?
10 Year(s)


Are you affilated in anyway with Jagex LTD?
no

Were you Referred to SRL?



What is your general programming knowledge?
beginner, I used to script before EOC and have just come back to oldschool RS, Having to learn all over again.


Are you a member of any other communities?
no


Tell us about yourself…

From: includer100
I have been playing on and off since runescape classic, Have just come back for the introduction of oldschool RS.
Before EOC scape and all the antibot technology I botted to a top 10 spot in the runecraft hiscores, and also have a top 10 woodcutter on oldschool RS thanks to my own basic private script.

I'd like to get back into scripting and help improve the general quality of botting in Oldschool RS.

The Script I have posted is fairly basic but it has got me to 99 woodcut without a single hitch, and once the antirandom is working fine I will be looking to make some high quality scripts.

Please show us one (or multiple) of your scripts.

program MonkeyTeakDropper;
    {$DEFINE SMART}
    {$I SRL/SRL.simba}
    {$I P07Include.simba}

    var
     x, y, XPGained ,XPGainedperhour, Logs, Logscut, Logscutperhour : Integer;

Procedure P07_DeclarePlayer;
begin;
      P07_PlayerName:='USERNAMEi';      //Enter Username and Password here so
      P07_PlayerPass:='PASSWORD';      //you can be logged in after disconnection
end;
Procedure Preparation;
begin;
      P07_LogInPlayer;                     //Logs you in, moves camera to the top
      P07_MakeCameraAngleHigh;             //and faces East.
      P07_MakeCompassEast;
end;
Procedure Progress;
begin;
      if P07_InvFull then;                 //Keeps track of Logs and XP.

      LogscutPerHour := Round((Logs * 3600) / (GetTimeRunning / 1000));
      XPGained := Round(Logs * 85);
      XPGainedPerHour := Round(((Logs * 85) * 3600) / (GetTimeRunning / 1000));
      Writeln('Time Running: ' + TimeRunning);
      Writeln('XP Gained: ' + IntToStr(XPGained));
      Writeln('XP Per Hour: ' + IntToStr(XPGainedPerHour));
      Writeln('Logs Cut: ' + IntToStr(Logs));
      Writeln('Logs Per Hour: ' + IntToStr(LogscutPerHour));
end;
Procedure Cutting;
begin;
      Repeat;
      Wait(RandomRange(3000,8000));
      if P07_FindObj(x, y, 'own', 6723505, 5) then
      begin;
      ClickMouse2(mouse_left);
      end; 
      Wait(RandomRange(10000,15000));
      begin;
      ClickMouse2(mouse_left);
      end;
      until not P07_IsUpTextMultiCustom(['Teak']) or(P07_InvFull); //Will click again once Tree falls or Inventory is full.

end;
Procedure Dropping;
begin;
      if P07_InvFull then
      P07_DropAllExcept([1]);  //Will drop all except the slots entered here.
      Logs:=Logs+27;                         //Change this number if you change the number of logs dropped.
end;
Procedure RetrieveAxe;
begin;
      if p07_FindObj(x, y, 'une', 6642243, 5) then     //if the script accidentally drops your axe,
      begin;                                           //this will pick it up again.
      ClickMouse2(mouse_left);
      end;
end;
Procedure MainLoop;
begin;                                    //Script will continue to look for axe and
      repeat                              //cut trees, until Inventory is full. It will
      RetrieveAxe;                        //then drop your logs and record progress.
      Cutting;
      if p07_invfull then
      begin;
      Dropping;
      Progress;
      end;
      until not (P07_LoggedIn)
end;

begin;
      SetupSRL();
      P07_DeclarePlayer;
      SetupP07Include;
      ActivateClient;
      Preparation;
      repeat
      if (P07_LoggedIn) then
      MainLoop;
      if not (P07_LoggedIn) then    //If you are logged out, this will log you back in.
      Preparation;
      Mainloop;
      until Logs=(10000)         //Script will not actually stop until you tell it to!


end.

I voted no based on your join date, and 13 posts. I also recommend reading this (http://villavu.com/forum/showthread.php?t=60288) very thoroughly, as your scripting standards are quite a mess.

As for your script, it is not advanced enough for a members application. You don't have any walking, TPA's, or anything more advanced then Find_Obj.

Also:

Procedure Dropping;
begin;
  if P07_InvFull then
    P07_DropAllExcept([1]);  
    Logs:=Logs+27; //This will execute whether the inventory is full or not.                         
end;

you should do this instead:

Procedure Dropping;
begin;
  if P07_InvFull then
  begin
    P07_DropAllExcept([1]);  
    Logs:=Logs+27; //Now this only executes if the inventory is full. 
  end;                          
end;

Hope to see you become more active and further your scripting.

Thanks for your feedback, but why would I need to make that particular change?
As it currently stands, the logs+27 will only execute when the inventory is full.

From: includer100
Thanks for your feedback, but why would I need to make that particular change?
As it currently stands, the logs+27 will only execute when the inventory is full.

If you have more than one command following an if…then statement then you need a begin and end.

Voting no purely based on activity sorry! Try to post more and be on the site for longer, SRL members is a community rank > all.

As noted by the previous people, your activity and scripting abilities can both be improved upon, but don't lose hope! Just work on both and perhaps in another few months another application can turn out much better!

Didn't make it this time. Take the suggestions given to you above, check out the tutorial island section, be active in the community and feel free to apply in 4 weeks time.

Cheers
Hobbit